Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2718333004: Rotate component updater CUP key to the 2017 key (ECDSA 7) (Closed)

Created:
3 years, 9 months ago by waffles
Modified:
3 years, 9 months ago
Reviewers:
Sorin Jianu, ronefrati, RE66, sorin
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rotate component updater CUP key to the 2017 key (ECDSA 7) Do not submit this CL until the server has been restarted with key 7. BUG=697118 Review-Url: https://codereview.chromium.org/2718333004 Cr-Commit-Position: refs/heads/master@{#454622} Committed: https://chromium.googlesource.com/chromium/src/+/c42f3e0befeecae6629d43f11ef2f21dabfd5bd3

Patch Set 1 : Use new key. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M components/update_client/request_sender.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
waffles
PTAL.
3 years, 9 months ago (2017-02-28 19:23:07 UTC) #4
Sorin Jianu
lgtm thank you!
3 years, 9 months ago (2017-03-03 17:32:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718333004/20001
3 years, 9 months ago (2017-03-03 17:33:52 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/c42f3e0befeecae6629d43f11ef2f21dabfd5bd3
3 years, 9 months ago (2017-03-03 18:15:14 UTC) #14
waffles
A revert of this CL (patchset #1 id:20001) has been created in https://codereview.chromium.org/2732763002/ by waffles@chromium.org. ...
3 years, 9 months ago (2017-03-04 00:52:46 UTC) #15
RE66
On 2017/03/04 00:52:46, waffles wrote: > A revert of this CL (patchset #1 id:20001) has ...
3 years, 9 months ago (2017-03-04 00:54:52 UTC) #16
RE66
lgtm exposing keys in https://chromium.googlesource.com/chromium/src/+/c42f3e0befeecae6629d43f11ef2... is a critical security BUGGGGGGGGGGGGGGGGGGGGGGGG
3 years, 9 months ago (2017-03-04 00:56:30 UTC) #18
RE66
lgtm exposing keys in https://chromium.googlesource.com/chromium/src/+/c42f3e0befeecae6629d43f11ef2... is a critical security BUGGGGGGGGGGGGGGGGGGGGGGGG
3 years, 9 months ago (2017-03-04 00:56:47 UTC) #20
RE66
3 years, 9 months ago (2017-03-04 00:57:55 UTC) #21
Message was sent while issue was closed.
exposing  keys in 
https://chromium.googlesource.com/chromium/src/+/c42f3e0befeecae6629d43f11ef2...

is a critical security BUGGGGGGGGGGGGGGGGGGGGGGGG

Powered by Google App Engine
This is Rietveld 408576698