Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2718333003: Remove unnecessary includes (Closed)

Created:
3 years, 9 months ago by Brian Osman
Modified:
3 years, 9 months ago
Reviewers:
tguilbert, bsalomon, vmpstr
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary includes These headers are going to be made private in Skia BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2718333003 Cr-Commit-Position: refs/heads/master@{#453920} Committed: https://chromium.googlesource.com/chromium/src/+/880dbcb4e33cc1795dcf7595fd4972869243c9fc

Patch Set 1 #

Total comments: 1

Patch Set 2 : GrTexture.h too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M cc/resources/resource_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/tiles/gpu_image_decode_cache.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M media/renderers/skcanvas_video_renderer.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
Brian Osman
3 years, 9 months ago (2017-02-28 18:12:58 UTC) #5
bsalomon
https://codereview.chromium.org/2718333003/diff/1/media/renderers/skcanvas_video_renderer.cc File media/renderers/skcanvas_video_renderer.cc (left): https://codereview.chromium.org/2718333003/diff/1/media/renderers/skcanvas_video_renderer.cc#oldcode25 media/renderers/skcanvas_video_renderer.cc:25: #include "third_party/skia/include/gpu/GrTexture.h" Can we remove this, too?
3 years, 9 months ago (2017-02-28 18:33:56 UTC) #7
Brian Osman
On 2017/02/28 18:33:56, bsalomon wrote: > https://codereview.chromium.org/2718333003/diff/1/media/renderers/skcanvas_video_renderer.cc > File media/renderers/skcanvas_video_renderer.cc (left): > > https://codereview.chromium.org/2718333003/diff/1/media/renderers/skcanvas_video_renderer.cc#oldcode25 > ...
3 years, 9 months ago (2017-02-28 18:44:22 UTC) #11
vmpstr
cc lgtm
3 years, 9 months ago (2017-02-28 23:19:34 UTC) #14
tguilbert
media LGTM
3 years, 9 months ago (2017-02-28 23:25:21 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718333003/20001
3 years, 9 months ago (2017-03-01 12:34:40 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 12:40:34 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/880dbcb4e33cc1795dcf7595fd49...

Powered by Google App Engine
This is Rietveld 408576698