Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 2718323002: Minor tweak to ComputedStyleBase.h.tmpl formatting (Closed)

Created:
3 years, 9 months ago by alancutter (OOO until 2018)
Modified:
3 years, 9 months ago
Reviewers:
sashab, shend
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews, sashab
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor tweak to ComputedStyleBase.h.tmpl formatting This patch changes the generated ComputedStyleBase.h code from: return true && m_listStyleType == o.m_listStyleType && m_textAlign == o.m_textAlign && m_writingMode == o.m_writingMode && m_direction == o.m_direction ; to: return ( m_listStyleType == o.m_listStyleType && m_textAlign == o.m_textAlign && m_writingMode == o.m_writingMode && m_direction == o.m_direction ); BUG=628043 Review-Url: https://codereview.chromium.org/2718323002 Cr-Commit-Position: refs/heads/master@{#453828} Committed: https://chromium.googlesource.com/chromium/src/+/3597c98b66546aa1dd3dea707570a3384dc7b922

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl View 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
alancutter (OOO until 2018)
3 years, 9 months ago (2017-02-28 06:50:22 UTC) #2
shend
On 2017/02/28 at 06:50:22, alancutter wrote: > Does this style follow the chromium style guide? ...
3 years, 9 months ago (2017-02-28 15:41:04 UTC) #3
sashab
Yup! This was a hack because I didn't know how to concatenate the fields in ...
3 years, 9 months ago (2017-02-28 23:25:42 UTC) #5
sashab
You can also add BUG=(the gen CS master bug) if you'd like
3 years, 9 months ago (2017-02-28 23:26:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718323002/1
3 years, 9 months ago (2017-03-01 00:55:52 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 03:39:21 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3597c98b66546aa1dd3dea707570...

Powered by Google App Engine
This is Rietveld 408576698