Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2718313003: Add switch to disable showing the search geolocation disclosure UI. (Closed)

Created:
3 years, 9 months ago by benwells
Modified:
3 years, 9 months ago
Reviewers:
raymes
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add switch to disable showing the search geolocation disclosure UI. This UI can impact perf tests, so a switch is being added to allow the impact to be disabled. BUG=681663 Review-Url: https://codereview.chromium.org/2718313003 Cr-Commit-Position: refs/heads/master@{#453777} Committed: https://chromium.googlesource.com/chromium/src/+/333a6dee3c08b91580f27ab196288bb7cdb21fdb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M chrome/browser/android/search_geolocation/search_geolocation_disclosure_tab_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/search_geolocation/search_geolocation_disclosure_tab_helper.cc View 4 chunks +7 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
benwells
The saga continues... apparently perf bots have stable finch configs enabled...
3 years, 9 months ago (2017-02-28 06:30:57 UTC) #4
raymes
lgtm - does something have to be changed to make the bots use it?
3 years, 9 months ago (2017-02-28 23:33:18 UTC) #7
benwells
On 2017/02/28 23:33:18, raymes wrote: > lgtm - does something have to be changed to ...
3 years, 9 months ago (2017-03-01 00:25:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718313003/1
3 years, 9 months ago (2017-03-01 00:26:28 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 00:45:36 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/333a6dee3c08b91580f27ab19628...

Powered by Google App Engine
This is Rietveld 408576698