MD Settings: checkbox: Support inverted when setting pref

MD Settings: checkbox: Support inverted when setting pref

BUG=662368
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2718253006
Cr-Commit-Position: refs/heads/master@{#454309}
Committed: https://chromium.googlesource.com/chromium/src/+/fa1515d170940a1887cf11a465068b82ea97e89d

[stevenjb, 2017-02-28 23:55:17]

Description was changed from

==========
MD Settings: checkbox: Support inverted when setting pref

BUG=662368
==========

to

==========
MD Settings: checkbox: Support inverted when setting pref

BUG=662368
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-03-01 00:07:04]

stevenjb@chromium.org changed reviewers:
+ dbeam@chromium.org, dschuyler@chromium.org

[Dan Beam, 2017-03-01 00:27:01]

lgtm

https://codereview.chromium.org/2718253006/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/settings_toggle_button_tests.js (right):

https://codereview.chromium.org/2718253006/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/settings_toggle_button_tests.js:68:
testElement.setAttribute('inverted', '');
nit: testElement.inverted = true;

https://codereview.chromium.org/2718253006/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/settings_toggle_button_tests.js:74:
testElement.set('pref', pref);
nit:

testElement.set('pref', {
  key: 'test',
  type: chrome.settingsPrivate.PrefType.BOOLEAN,
  value: true
});

[stevenjb, 2017-03-01 00:35:13]

https://codereview.chromium.org/2718253006/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/settings_toggle_button_tests.js (right):

https://codereview.chromium.org/2718253006/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/settings_toggle_button_tests.js:68:
testElement.setAttribute('inverted', '');
On 2017/03/01 00:27:00, Dan Beam wrote:
> nit: testElement.inverted = true;

Done.

https://codereview.chromium.org/2718253006/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/settings_toggle_button_tests.js:74:
testElement.set('pref', pref);
On 2017/03/01 00:27:00, Dan Beam wrote:
> nit:
> 
> testElement.set('pref', {
>   key: 'test',
>   type: chrome.settingsPrivate.PrefType.BOOLEAN,
>   value: true
> });

Done.

[stevenjb, 2017-03-01 00:35:19]

The CQ bit was checked by stevenjb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 00:35:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 01:27:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 01:27:47]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[stevenjb, 2017-03-02 17:16:32]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-03-02 17:16:33]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2718253006/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-02 17:16:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 18:14:39]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488474992749000,
"parent_rev": "8c68311a3f7c731ecf774e4ac411bbd2179436fb", "commit_rev":
"fa1515d170940a1887cf11a465068b82ea97e89d"}

[commit-bot: I haz the power, 2017-03-02 18:15:30]

Description was changed from

==========
MD Settings: checkbox: Support inverted when setting pref

BUG=662368
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: checkbox: Support inverted when setting pref

BUG=662368
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2718253006
Cr-Commit-Position: refs/heads/master@{#454309}
Committed:
https://chromium.googlesource.com/chromium/src/+/fa1515d170940a1887cf11a46506...
==========

[commit-bot: I haz the power, 2017-03-02 18:15:32]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/fa1515d170940a1887cf11a46506...