Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2718253004:
MacViews: Fix compilation. (Closed)
DescriptionMacViews: Fix compilation.
The MacViews compilation broken by CL:
https://codereview.chromium.org/2700243002
location_bar_view_mac_unittest.mm file can not be compiled for MacViews.
BUG=425229
Review-Url: https://codereview.chromium.org/2718253004
Cr-Commit-Position: refs/heads/master@{#453758}
Committed: https://chromium.googlesource.com/chromium/src/+/21c1a423cbb3143adc594ac445a427179923578b
Patch Set 1 #
Messages
Total messages: 19 (11 generated)
Description was changed from ========== MacViews: Fix compilation. The MacViews compilation already broken by CL: https://codereview.chromium.org/2700243002 location_bar_view_mac_unittest.mm file can not be compiled for MacViews. ========== to ========== MacViews: Fix compilation. The MacViews compilation broken by CL: https://codereview.chromium.org/2700243002 location_bar_view_mac_unittest.mm file can not be compiled for MacViews. ==========
art-snake@yandex-team.ru changed reviewers: + ellyjones@chromium.org, rsesek@chromium.org, spqchan@chromium.org
The CQ bit was checked by art-snake@yandex-team.ru to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== MacViews: Fix compilation. The MacViews compilation broken by CL: https://codereview.chromium.org/2700243002 location_bar_view_mac_unittest.mm file can not be compiled for MacViews. ========== to ========== MacViews: Fix compilation. The MacViews compilation broken by CL: https://codereview.chromium.org/2700243002 location_bar_view_mac_unittest.mm file can not be compiled for MacViews. BUG=425229 ==========
tapted@chromium.org changed reviewers: + tapted@chromium.org
I added BUG=425229 for you (I have a collection). (also lgtm)
I'm just gonna CQ this.
The CQ bit was checked by tapted@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1488323374689680, "parent_rev":
"300faa7fd9de9dee72b268ae2a5347aa10bf1dde", "commit_rev":
"21c1a423cbb3143adc594ac445a427179923578b"}
Message was sent while issue was closed.
Description was changed from ========== MacViews: Fix compilation. The MacViews compilation broken by CL: https://codereview.chromium.org/2700243002 location_bar_view_mac_unittest.mm file can not be compiled for MacViews. BUG=425229 ========== to ========== MacViews: Fix compilation. The MacViews compilation broken by CL: https://codereview.chromium.org/2700243002 location_bar_view_mac_unittest.mm file can not be compiled for MacViews. BUG=425229 Review-Url: https://codereview.chromium.org/2718253004 Cr-Commit-Position: refs/heads/master@{#453758} Committed: https://chromium.googlesource.com/chromium/src/+/21c1a423cbb3143adc594ac445a4... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/21c1a423cbb3143adc594ac445a4... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
