Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 2718243003: Reduce the set of WoSign/StartCom domains to the Alexa Top 500K (Closed)

Created:
3 years, 9 months ago by Ryan Sleevi
Modified:
3 years, 9 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce the set of WoSign/StartCom domains to the Alexa Top 500K As part of phasing out trust in WoSign/StartCom-issued certificates, reduce the domain whitelist from the top 1M to the top 500K. This reduces the overall binary impact from 113K to 65K. BUG=685826 Review-Url: https://codereview.chromium.org/2718243003 Cr-Commit-Position: refs/heads/master@{#453445} Committed: https://chromium.googlesource.com/chromium/src/+/6fc397860ccafa55086456a4d1e6d713c418b41f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7253 lines) Patch
M net/data/ssl/wosign/wosign_domains.gperf View 158 chunks +2 lines, -7253 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Ryan Sleevi
Everybody loves shaving >50K off binaries, right? :)
3 years, 9 months ago (2017-02-27 23:25:47 UTC) #2
eroman
lgtm
3 years, 9 months ago (2017-02-27 23:59:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718243003/1
3 years, 9 months ago (2017-02-28 00:02:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/163064)
3 years, 9 months ago (2017-02-28 01:12:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718243003/1
3 years, 9 months ago (2017-02-28 01:19:41 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 01:56:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6fc397860ccafa55086456a4d1e6...

Powered by Google App Engine
This is Rietveld 408576698