Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2718243002: cc: Regenerate image decode requests tasks when cache switches. (Closed)

Created:
3 years, 9 months ago by vmpstr
Modified:
3 years, 9 months ago
Reviewers:
enne (OOO), Khushal
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Regenerate image decode requests tasks when cache switches. Right now, when we switch the cache, we fail any decode that was enqueued but not yet processed or processed but the callback wasn't issued yet. This patch makes these requests orphaned instead, and if a new cache is set, then it regenerates the tasks from the new cache and processes them. If, however, the dtor runs, then the callbacks are issued with the failure code. BUG=693692 R=khushalsagar@chromium.org, enne@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2718243002 Cr-Commit-Position: refs/heads/master@{#453471} Committed: https://chromium.googlesource.com/chromium/src/+/f5cbd80af75b987838cd8da22416edef4fc18355

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -25 lines) Patch
M cc/tiles/decoded_image_tracker_unittest.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M cc/tiles/image_controller.h View 2 chunks +7 lines, -0 lines 0 comments Download
M cc/tiles/image_controller.cc View 7 chunks +42 lines, -15 lines 0 comments Download
M cc/tiles/image_controller_unittest.cc View 1 4 chunks +55 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
vmpstr
Please take a look.
3 years, 9 months ago (2017-02-27 23:01:02 UTC) #2
Khushal
lgtm
3 years, 9 months ago (2017-02-28 00:37:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718243002/20001
3 years, 9 months ago (2017-02-28 01:12:40 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 02:36:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f5cbd80af75b987838cd8da22416...

Powered by Google App Engine
This is Rietveld 408576698