Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2718193002: Prevent handle MouseUp when mouse is capture a scrollbar (Closed)

Created:
3 years, 9 months ago by chaopeng
Modified:
3 years, 9 months ago
Reviewers:
weiliangc
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent handle MouseUp when mouse is capture a scrollbar In this patch, we add a captured check in ScrollbarAnimationController::DidMouseUp. BUG=696717 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2718193002 Cr-Commit-Position: refs/heads/master@{#454277} Committed: https://chromium.googlesource.com/chromium/src/+/7e682316e7b28920d1dfd8bdc1b4623a15062804

Patch Set 1 : add captured check in mouse up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M cc/input/scrollbar_animation_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 23 (19 generated)
chaopeng
PTAL. Thank you.
3 years, 9 months ago (2017-02-27 21:40:03 UTC) #15
weiliangc
LGTM
3 years, 9 months ago (2017-02-27 21:41:43 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718193002/40001
3 years, 9 months ago (2017-03-02 15:40:37 UTC) #20
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 16:27:00 UTC) #23
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7e682316e7b28920d1dfd8bdc1b4...

Powered by Google App Engine
This is Rietveld 408576698