Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5001)

Unified Diff: chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.js

Issue 2718133004: ChromeOS OOBE: More accessibility fixes. (Closed)
Patch Set: Update after review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.js
diff --git a/chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.js b/chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.js
index 7e7253a9c29968655705b965733c6115178607b5..ff5835a2eeeb5e40a6521d8267593d562b180d82 100644
--- a/chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.js
+++ b/chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.js
@@ -29,6 +29,10 @@ Polymer({
/**
* ARIA-label for the selection menu.
+ *
+ * Note that we are not using "aria-label" property here, because
+ * we want to pass the label value but not actually declare it as an
+ * ARIA property anywhere but the actual target element.
*/
labelForAria: String,
},
« no previous file with comments | « chrome/browser/resources/chromeos/login/oobe_eula.html ('k') | chrome/browser/resources/chromeos/login/oobe_welcome.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698