Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3185)

Unified Diff: chrome/browser/resources/chromeos/login/oobe_eula.html

Issue 2718133004: ChromeOS OOBE: More accessibility fixes. (Closed)
Patch Set: Update after review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/login/oobe_eula.html
diff --git a/chrome/browser/resources/chromeos/login/oobe_eula.html b/chrome/browser/resources/chromeos/login/oobe_eula.html
index 12958f59e50ea6e00e9588339f169c72993f6dce..ddb9bf8fa8238f86fc32e45bcaa476b83b70a2e5 100644
--- a/chrome/browser/resources/chromeos/login/oobe_eula.html
+++ b/chrome/browser/resources/chromeos/login/oobe_eula.html
@@ -28,7 +28,7 @@
<link rel="stylesheet" href="oobe_eula.css">
<link rel="stylesheet" href="oobe_dialog_parameters.css">
<oobe-dialog id="eulaLoadingDialog" hidden="[[!eulaLoadingScreenShown]]"
- role="dialog" aria-label="$i18n{termsOfServiceLoading}"
+ role="dialog" aria-label$="$i18n{termsOfServiceLoading}"
has-buttons>
<iron-icon icon="oobe-eula:googleg" class="oobe-icon"></iron-icon>
<div class="header">
@@ -36,7 +36,7 @@
</div>
</oobe-dialog>
<oobe-dialog id="eulaDialog" hidden="[[eulaLoadingScreenShown]]"
- role="dialog" aria-label="$i18n{oobeEulaSectionTitle}"
+ role="dialog" aria-label$="$i18n{oobeEulaSectionTitle}"
has-buttons>
<iron-icon icon="oobe-eula:googleg" class="oobe-icon"></iron-icon>
<div class="header">
@@ -45,22 +45,24 @@
<div class="footer flex layout vertical">
<iframe id="crosEulaFrame" src="chrome://terms"
role="document" class="flex focus-on-show"
- aria-label="$i18n{oobeEulaIframeLabel}"
+ aria-label$="$i18n{oobeEulaIframeLabel}"
on-load="onFrameLoad_">
</iframe>
<a id="installationSettings" href="#"
on-tap="onInstallationSettingsClicked_"
i18n-content="eulaSystemInstallationSettings">
</a>
- <div id="logging">
+ <div id="logging" class="layout horizontal">
<paper-checkbox aria-labelledby="usage-stats-label" id="usageStats"
checked="{{usageStatsChecked}}" on-change="onUsageChanged_">
+ </paper-checkbox>
+ <div id="usageStatsLabelContainer">
<label id="usage-stats-label" i18n-content="checkboxLogging">
</label>
<a id="" href="#" i18n-content="learnMore"
on-tap="onUsageStatsHelpLinkClicked_">
</a>
- </paper-checkbox>
+ </div>
</div>
</div>
<div class="bottom-buttons flex layout horizontal">
« no previous file with comments | « chrome/browser/resources/chromeos/login/oobe_eula.css ('k') | chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698