Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1281)

Unified Diff: extensions/renderer/object_backed_native_handler.cc

Issue 2718133003: Rewrite extensions console to not leak function templates. (Closed)
Patch Set: devlin Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/module_system.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/object_backed_native_handler.cc
diff --git a/extensions/renderer/object_backed_native_handler.cc b/extensions/renderer/object_backed_native_handler.cc
index 7346e392c38241bc4e60a57d4120a70178123208..ee85a3d70172e5a571053c61a0241eacc57add52 100644
--- a/extensions/renderer/object_backed_native_handler.cc
+++ b/extensions/renderer/object_backed_native_handler.cc
@@ -57,8 +57,10 @@ void ObjectBackedNativeHandler::Router(
!feature_name_value->IsString()) {
ScriptContext* script_context =
ScriptContextSet::GetContextByV8Context(context);
- console::Error(script_context ? script_context->GetRenderFrame() : nullptr,
- "Extension view no longer exists");
+ console::AddMessage(
+ script_context ? script_context->GetRenderFrame() : nullptr,
+ content::CONSOLE_MESSAGE_LEVEL_ERROR,
+ "Extension view no longer exists");
return;
}
« no previous file with comments | « extensions/renderer/module_system.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698