Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Unified Diff: extensions/renderer/module_system.cc

Issue 2718133003: Rewrite extensions console to not leak function templates. (Closed)
Patch Set: devlin Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/console.cc ('k') | extensions/renderer/object_backed_native_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/module_system.cc
diff --git a/extensions/renderer/module_system.cc b/extensions/renderer/module_system.cc
index 31d2db8d69d87b8a40082104321775ca62ae6e30..a7918f5b23c70e1656deddaebf9f4f1cb4029a76 100644
--- a/extensions/renderer/module_system.cc
+++ b/extensions/renderer/module_system.cc
@@ -60,7 +60,8 @@ void Fatal(ScriptContext* context, const std::string& message) {
ExtensionsClient* client = ExtensionsClient::Get();
if (client->ShouldSuppressFatalErrors()) {
- console::Error(context->GetRenderFrame(), full_message);
+ console::AddMessage(context->GetRenderFrame(),
+ content::CONSOLE_MESSAGE_LEVEL_ERROR, full_message);
client->RecordDidSuppressFatalError();
} else {
console::Fatal(context->GetRenderFrame(), full_message);
@@ -70,8 +71,9 @@ void Fatal(ScriptContext* context, const std::string& message) {
void Warn(v8::Isolate* isolate, const std::string& message) {
ScriptContext* script_context =
ScriptContextSet::GetContextByV8Context(isolate->GetCurrentContext());
- console::Warn(script_context ? script_context->GetRenderFrame() : nullptr,
- message);
+ console::AddMessage(
+ script_context ? script_context->GetRenderFrame() : nullptr,
+ content::CONSOLE_MESSAGE_LEVEL_WARNING, message);
}
// Default exception handler which logs the exception.
« no previous file with comments | « extensions/renderer/console.cc ('k') | extensions/renderer/object_backed_native_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698