Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 2718123004: Add more info to histograms.xml about omnibox metrics. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months, 3 weeks ago by Alexei Svitkine (slow)
Modified:
7 months, 3 weeks ago
Reviewers:
Mark P
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more info to histograms.xml about omnibox metrics. Gives some breakdown info for Omnibox.CharTypedToRepaintLatency and also adds mpearson@ as an owner to a couple of them. BUG=none Review-Url: https://codereview.chromium.org/2718123004 Cr-Commit-Position: refs/heads/master@{#453359} Committed: https://chromium.googlesource.com/chromium/src/+/5490ff516d4e1d301aaf9058a3ba959ba23643b3

Patch Set 1 #

Total comments: 2

Patch Set 2 : Tweak description. #

Messages

Total messages: 14 (7 generated)
Alexei Svitkine (slow)
7 months, 3 weeks ago (2017-02-27 20:33:37 UTC) #2
Mark P
lgtm modulo nit https://codereview.chromium.org/2718123004/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2718123004/diff/1/tools/metrics/histograms/histograms.xml#newcode42944 tools/metrics/histograms/histograms.xml:42944: + Omnibox.QueryTime2 is a good proxy ...
7 months, 3 weeks ago (2017-02-27 20:51:29 UTC) #3
Alexei Svitkine (slow)
https://codereview.chromium.org/2718123004/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2718123004/diff/1/tools/metrics/histograms/histograms.xml#newcode42944 tools/metrics/histograms/histograms.xml:42944: + Omnibox.QueryTime2 is a good proxy for a) and ...
7 months, 3 weeks ago (2017-02-27 21:01:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718123004/20001
7 months, 3 weeks ago (2017-02-27 21:03:10 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/396566)
7 months, 3 weeks ago (2017-02-27 21:46:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718123004/20001
7 months, 3 weeks ago (2017-02-27 21:55:52 UTC) #11
commit-bot: I haz the power
7 months, 3 weeks ago (2017-02-27 22:27:39 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5490ff516d4e1d301aaf9058a3ba...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa