|
|
DescriptionFix nits from earlier CLs
BUG=None
Review-Url: https://codereview.chromium.org/2718123002
Cr-Commit-Position: refs/heads/master@{#455879}
Committed: https://chromium.googlesource.com/chromium/src/+/ea6067deecab4ff2a010bcb01e9bfb76fe7a88bf
Patch Set 1 #
Total comments: 1
Messages
Total messages: 38 (21 generated)
The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run
Description was changed from ========== Fix nits from earlier CLs BUG=None ========== to ========== Fix nits from earlier CLs BUG=None ==========
rbpotter@chromium.org changed reviewers: + thestig@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Fixes for comments from earlier CLs: https://codereview.chromium.org/2524143003/ https://codereview.chromium.org/2616783002/ https://codereview.chromium.org/2683653005/
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm, but you need a security reviewer for the trivial IPC message change.
rbpotter@chromium.org changed reviewers: + tsepez@chromium.org
trivial LGTM
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
rbpotter@chromium.org changed reviewers: + vollick@chromium.org
Changed ordering of DEPS to alphabetical.
rbpotter@chromium.org changed reviewers: + dcheng@chromium.org - vollick@chromium.org
Need review from ui/gfx owner as I changed the ordering in a DEPS file to be alphabetical and it includes files from this folder.
RS LGTM
Weird, we should fix the presubmit to not complain about this, but lgtm in the meantime
Filed https://bugs.chromium.org/p/chromium/issues/detail?id=700108 for the presubmit check.
The CQ bit was checked by rbpotter@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
rbpotter@chromium.org changed reviewers: + danakj@chromium.org
+danakj for ui/gfx/geometry... CL changes ordering a in DEPS file.
https://codereview.chromium.org/2718123002/diff/1/pdf/pdfium/DEPS File pdf/pdfium/DEPS (right): https://codereview.chromium.org/2718123002/diff/1/pdf/pdfium/DEPS#newcode7 pdf/pdfium/DEPS:7: "+ui/gfx/codec/jpeg_codec.h", LGTM
The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rbpotter@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1489097433779700, "parent_rev": "1372b49c583067437e3e42574fd55199bd7d5a28", "commit_rev": "ea6067deecab4ff2a010bcb01e9bfb76fe7a88bf"}
Message was sent while issue was closed.
Description was changed from ========== Fix nits from earlier CLs BUG=None ========== to ========== Fix nits from earlier CLs BUG=None Review-Url: https://codereview.chromium.org/2718123002 Cr-Commit-Position: refs/heads/master@{#455879} Committed: https://chromium.googlesource.com/chromium/src/+/ea6067deecab4ff2a010bcb01e9b... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ea6067deecab4ff2a010bcb01e9b... |