Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2718123002: Fix nits from earlier CLs (Closed)

Created:
3 years, 9 months ago by rbpotter
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix nits from earlier CLs BUG=None Review-Url: https://codereview.chromium.org/2718123002 Cr-Commit-Position: refs/heads/master@{#455879} Committed: https://chromium.googlesource.com/chromium/src/+/ea6067deecab4ff2a010bcb01e9bfb76fe7a88bf

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -18 lines) Patch
M chrome/browser/ui/webui/print_preview/print_preview_ui.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/data/webui/print_preview.js View 6 chunks +12 lines, -10 lines 0 comments Download
M components/printing/common/print_messages.h View 2 chunks +3 lines, -3 lines 0 comments Download
M pdf/pdfium/DEPS View 1 chunk +1 line, -1 line 1 comment Download
M pdf/pdfium/pdfium_engine.cc View 1 chunk +4 lines, -1 line 0 comments Download
M printing/print_job_constants.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 38 (21 generated)
rbpotter
Fixes for comments from earlier CLs: https://codereview.chromium.org/2524143003/ https://codereview.chromium.org/2616783002/ https://codereview.chromium.org/2683653005/
3 years, 9 months ago (2017-02-27 17:25:11 UTC) #5
Lei Zhang
lgtm, but you need a security reviewer for the trivial IPC message change.
3 years, 9 months ago (2017-02-27 19:50:22 UTC) #8
rbpotter
3 years, 9 months ago (2017-02-27 20:01:19 UTC) #10
Tom Sepez
trivial LGTM
3 years, 9 months ago (2017-02-27 20:20:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718123002/1
3 years, 9 months ago (2017-02-27 20:22:40 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/373789)
3 years, 9 months ago (2017-02-27 20:34:06 UTC) #15
rbpotter
Changed ordering of DEPS to alphabetical.
3 years, 9 months ago (2017-02-27 20:35:19 UTC) #17
rbpotter
Need review from ui/gfx owner as I changed the ordering in a DEPS file to ...
3 years, 9 months ago (2017-03-09 17:48:46 UTC) #19
Tom Sepez
RS LGTM
3 years, 9 months ago (2017-03-09 17:50:52 UTC) #20
dcheng
Weird, we should fix the presubmit to not complain about this, but lgtm in the ...
3 years, 9 months ago (2017-03-09 19:12:46 UTC) #21
dcheng
Filed https://bugs.chromium.org/p/chromium/issues/detail?id=700108 for the presubmit check.
3 years, 9 months ago (2017-03-09 19:17:20 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718123002/1
3 years, 9 months ago (2017-03-09 20:03:08 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/382222)
3 years, 9 months ago (2017-03-09 20:12:09 UTC) #26
rbpotter
+danakj for ui/gfx/geometry... CL changes ordering a in DEPS file.
3 years, 9 months ago (2017-03-09 20:20:09 UTC) #28
danakj
https://codereview.chromium.org/2718123002/diff/1/pdf/pdfium/DEPS File pdf/pdfium/DEPS (right): https://codereview.chromium.org/2718123002/diff/1/pdf/pdfium/DEPS#newcode7 pdf/pdfium/DEPS:7: "+ui/gfx/codec/jpeg_codec.h", LGTM
3 years, 9 months ago (2017-03-09 20:49:05 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718123002/1
3 years, 9 months ago (2017-03-09 22:10:59 UTC) #35
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 22:17:46 UTC) #38
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ea6067deecab4ff2a010bcb01e9b...

Powered by Google App Engine
This is Rietveld 408576698