Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2718093002: Format HpackEntry initializer lists. (Closed)

Created:
3 years, 9 months ago by Bence
Modified:
3 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Format HpackEntry initializer lists. This is a follow-up to https://crrev.com/2663203002. While https://crrev.com/2663203002 is properly formatted, it turns out that the internally used clang-format is stricter. This CL changes formatting to a style that is accepted by both Chromium's clang-format and the internal one. BUG=680056 Review-Url: https://codereview.chromium.org/2718093002 Cr-Commit-Position: refs/heads/master@{#453340} Committed: https://chromium.googlesource.com/chromium/src/+/a73f729a9a20ca911ced2e9896bf3c5aad95fe27

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M net/spdy/hpack/hpack_decoder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/hpack/hpack_entry.cc View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Bence
Ryan: PTAL. I knew that Chromium's git cl format might allow either of multiple alternatives ...
3 years, 9 months ago (2017-02-27 16:24:17 UTC) #6
Ryan Hamilton
LGTM. I'm surprised that chromium's format allowed those. *head explodes*
3 years, 9 months ago (2017-02-27 19:44:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718093002/1
3 years, 9 months ago (2017-02-27 21:06:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a73f729a9a20ca911ced2e9896bf3c5aad95fe27
3 years, 9 months ago (2017-02-27 21:18:03 UTC) #12
Bence
3 years, 9 months ago (2017-02-27 22:53:39 UTC) #13
Message was sent while issue was closed.
On 2017/02/27 19:44:15, Ryan Hamilton wrote:
> LGTM. I'm surprised that chromium's format allowed those. *head explodes*

I'm surprised too.  What's even more confusing is the following: if I locally
revert https://crrev.com/2663203002, then re-land, then reset commit, then
stage, then run git cl format, then it does not make any modifications.  In
other words, https://crrev.com/2663203002 is properly git cl formatted. 
However, if I revert this CL locally, then reset commit, then stage, then run
git cl format, then git cl format really does not the change, and reverts the
revert entirely.  Something is not working right, or I am holding it all wrong.

Powered by Google App Engine
This is Rietveld 408576698