Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2718073005: Revert of [Media Router] Remove binary messaging implementation. (Closed)

Created:
3 years, 9 months ago by mark a. foltz
Modified:
3 years, 9 months ago
Reviewers:
whywhat
CC:
agrieve+watch_chromium.org, chfremer+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, media-router+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Media Router] Remove binary messaging implementation. (patchset #1 id:1 of https://codereview.chromium.org/2720273003/ ) Reason for revert: Broke Android unittests Original issue's description: > [Media Router] Remove binary messaging implementation. > > This removes the binary messaging implementation for Media Router from Android, > as there are no plans to support it for Cast. > > BUG=524128 > R=avayvod@chromium.org > > Review-Url: https://codereview.chromium.org/2720273003 . > Cr-Commit-Position: refs/heads/master@{#453709} > Committed: https://chromium.googlesource.com/chromium/src/+/ebdab4190ceb21a9ba4a5d8e719df9ab94b2716e TBR=avayvod@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=524128

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouter.java View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/router/MediaRouteProvider.java View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/media/android/router/media_router_android.cc View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
mark a. foltz
Created Revert of [Media Router] Remove binary messaging implementation.
3 years, 9 months ago (2017-02-28 22:30:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718073005/1
3 years, 9 months ago (2017-02-28 22:30:49 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 22:31:56 UTC) #5
Failed to apply patch for
chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouter.java:
While running git apply --index -p1;
  error: patch failed:
chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouter.java:325
  error:
chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouter.java:
patch does not apply

Patch:      
chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouter.java
Index:
chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouter.java
diff --git
a/chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouter.java
b/chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouter.java
index
a4e96c4da74363269c4981d97656b72dc3bee6f7..9236349266cbd2af670f208acdfa62439eaae286
100644
---
a/chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouter.java
+++
b/chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouter.java
@@ -325,6 +325,23 @@
         }
 
         provider.sendStringMessage(routeId, message, callbackId);
+    }
+
+    /**
+     * Sends a binary message to the specified route.
+     * @param routeId The id of the route to send the message to.
+     * @param data The binary message to send.
+     * @param callbackId The id of the result callback tracked by the native
side.
+     */
+    @CalledByNative
+    public void sendBinaryMessage(String routeId, byte[] data, int callbackId)
{
+        MediaRouteProvider provider = mRouteIdsToProviders.get(routeId);
+        if (provider == null) {
+            nativeOnMessageSentResult(mNativeMediaRouterAndroid, false,
callbackId);
+            return;
+        }
+
+        provider.sendBinaryMessage(routeId, data, callbackId);
     }
 
     @VisibleForTesting

Powered by Google App Engine
This is Rietveld 408576698