Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3066)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java

Issue 2718073005: Revert of [Media Router] Remove binary messaging implementation. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java b/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java
index 211afd2abe62ee8d4ff38b4454ab578407580258..e687e5ba06f91b161359b5fe1c52e4eed80ac72c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java
@@ -376,6 +376,15 @@
mManager.onMessageSentResult(success, nativeCallbackId);
}
+ @Override
+ public void sendBinaryMessage(String routeId, byte[] data, int nativeCallbackId) {
+ // TODO(crbug.com/524128): Cast API does not support sending binary message
+ // to receiver application. Binary data may be converted to String and send as
+ // an app_message within it's own message namespace, using the string version.
+ // Sending failure in the result callback for now.
+ mManager.onMessageSentResult(false, nativeCallbackId);
+ }
+
private boolean handleClientConnectMessage(JSONObject jsonMessage) throws JSONException {
String clientId = jsonMessage.getString("clientId");
if (clientId == null) return false;

Powered by Google App Engine
This is Rietveld 408576698