Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Unified Diff: ui/views/accessibility/native_view_accessibility_win.cc

Issue 2718073003: Views a11y: Convert View's NativeViewAccessibility to a unique_ptr. (Closed)
Patch Set: Fix compile error. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/accessibility/native_view_accessibility_win.cc
diff --git a/ui/views/accessibility/native_view_accessibility_win.cc b/ui/views/accessibility/native_view_accessibility_win.cc
index fee8d9ea336fa39768baa123ff707b0b1d7fd2d8..794fc5c643fbadcd12237fe8e521521dcf7dafbc 100644
--- a/ui/views/accessibility/native_view_accessibility_win.cc
+++ b/ui/views/accessibility/native_view_accessibility_win.cc
@@ -6,9 +6,11 @@
#include <oleacc.h>
+#include <memory>
#include <set>
#include <vector>
+#include "base/memory/ptr_util.h"
#include "base/memory/singleton.h"
#include "base/strings/utf_string_conversions.h"
#include "base/win/scoped_comptr.h"
@@ -27,18 +29,6 @@
namespace views {
-// static
-NativeViewAccessibility* NativeViewAccessibility::Create(View* view) {
- return new NativeViewAccessibilityWin(view);
-}
-
-NativeViewAccessibilityWin::NativeViewAccessibilityWin(View* view)
- : NativeViewAccessibility(view) {
-}
-
-NativeViewAccessibilityWin::~NativeViewAccessibilityWin() {
-}
-
gfx::NativeViewAccessible NativeViewAccessibilityWin::GetParent() {
IAccessible* parent = NativeViewAccessibility::GetParent();
if (parent)
@@ -62,4 +52,15 @@ NativeViewAccessibilityWin::GetTargetForNativeAccessibilityEvent() {
return HWNDForView(view_);
}
+NativeViewAccessibilityWin::NativeViewAccessibilityWin(View* view)
tapted 2017/02/28 06:29:12 The two NativeViewAccessibilityWin methods should
Patti Lor 2017/02/28 22:24:24 Took the first option to match what they were orig
+ : NativeViewAccessibility(view) {}
+
+NativeViewAccessibilityWin::~NativeViewAccessibilityWin() {}
+
+// static
+std::unique_ptr<NativeViewAccessibility> NativeViewAccessibility::Create(
+ View* view) {
+ return base::MakeUnique<NativeViewAccessibilityWin>(view);
+}
+
} // namespace views

Powered by Google App Engine
This is Rietveld 408576698