Views a11y: Convert View's NativeViewAccessibility to a unique_ptr.

ui/views/accessibility/native_view_accessibility_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/accessibility/native_view_accessibility_win.h"
 
 #include <oleacc.h>
 
+#include <memory>
 #include <set>
 #include <vector>
 
+#include "base/memory/ptr_util.h"
 #include "base/memory/singleton.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/win/scoped_comptr.h"
 #include "base/win/windows_version.h"
 #include "third_party/iaccessible2/ia2_api_all.h"
 #include "ui/accessibility/ax_enums.h"
 #include "ui/accessibility/ax_node_data.h"
 #include "ui/accessibility/ax_text_utils.h"
 #include "ui/base/win/accessibility_misc_utils.h"
 #include "ui/base/win/atl_module.h"
 #include "ui/views/controls/button/custom_button.h"
 #include "ui/views/focus/focus_manager.h"
 #include "ui/views/focus/view_storage.h"
 #include "ui/views/widget/widget.h"
 #include "ui/views/win/hwnd_util.h"
 
 namespace views {
 
-// static
-NativeViewAccessibility* NativeViewAccessibility::Create(View* view) {
-  return new NativeViewAccessibilityWin(view);
-}
-
-NativeViewAccessibilityWin::NativeViewAccessibilityWin(View* view)
-    : NativeViewAccessibility(view) {
-}
-
-NativeViewAccessibilityWin::~NativeViewAccessibilityWin() {
-}
-
 gfx::NativeViewAccessible NativeViewAccessibilityWin::GetParent() {
   IAccessible* parent = NativeViewAccessibility::GetParent();
   if (parent)
     return parent;
 
   HWND hwnd = HWNDForView(view_);
   if (!hwnd)
     return NULL;
 
   HRESULT hr = ::AccessibleObjectFromWindow(
       hwnd, OBJID_WINDOW, IID_IAccessible,
       reinterpret_cast<void**>(&parent));
   if (SUCCEEDED(hr))
     return parent;
 
   return NULL;
 }
 
 gfx::AcceleratedWidget
 NativeViewAccessibilityWin::GetTargetForNativeAccessibilityEvent() {
   return HWNDForView(view_);
 }
 
+NativeViewAccessibilityWin::NativeViewAccessibilityWin(View* view)

[tapted, 2017/02/28 06:29:12]

The two NativeViewAccessibilityWin methods should be put back where they were to
match the .h. 

 - Create() can stay where it was too (in which case update AuraLinux), or
 - Create() can stay down here (in which case update Mac) :)

[Patti Lor, 2017/02/28 22:24:24]

Took the first option to match what they were originally like. Sorry, I checked
them out from my old branch before edits and didn't think about whether the
reorders still made sense, but it should be good now.

+    : NativeViewAccessibility(view) {}
+
+NativeViewAccessibilityWin::~NativeViewAccessibilityWin() {}
+
+// static
+std::unique_ptr<NativeViewAccessibility> NativeViewAccessibility::Create(
+    View* view) {
+  return base::MakeUnique<NativeViewAccessibilityWin>(view);
+}
+
 }  // namespace views