Views a11y: Convert View's NativeViewAccessibility to a unique_ptr.

ui/views/accessibility/native_view_accessibility_auralinux.cc

Index: ui/views/accessibility/native_view_accessibility_auralinux.cc
diff --git a/ui/views/accessibility/native_view_accessibility_auralinux.cc b/ui/views/accessibility/native_view_accessibility_auralinux.cc
index 5ee10f8f32901010a87d7d52d56f7d2e679a0f80..959f79bd0a675690a0136ae203a5e1d474b6c886 100644
--- a/ui/views/accessibility/native_view_accessibility_auralinux.cc
+++ b/ui/views/accessibility/native_view_accessibility_auralinux.cc
@@ -5,9 +5,11 @@
 #include "ui/views/accessibility/native_view_accessibility_auralinux.h"
 
 #include <algorithm>
+#include <memory>
 #include <vector>
 
 #include "base/macros.h"
+#include "base/memory/ptr_util.h"
 #include "base/memory/singleton.h"
 #include "base/stl_util.h"
 #include "ui/accessibility/ax_action_data.h"
@@ -149,10 +151,11 @@ class AuraLinuxApplication
 
 }  // namespace
 
-// static
-NativeViewAccessibility* NativeViewAccessibility::Create(View* view) {
-  AuraLinuxApplication::GetInstance()->RegisterWidget(view->GetWidget());
-  return new NativeViewAccessibilityAuraLinux(view);
+gfx::NativeViewAccessible NativeViewAccessibilityAuraLinux::GetParent() {
+  gfx::NativeViewAccessible parent = NativeViewAccessibility::GetParent();
+  if (!parent)
+    parent = AuraLinuxApplication::GetInstance()->GetNativeViewAccessible();
+  return parent;
 }
 
 NativeViewAccessibilityAuraLinux::NativeViewAccessibilityAuraLinux(View* view)
@@ -162,11 +165,11 @@ NativeViewAccessibilityAuraLinux::NativeViewAccessibilityAuraLinux(View* view)
 NativeViewAccessibilityAuraLinux::~NativeViewAccessibilityAuraLinux() {
 }
 
-gfx::NativeViewAccessible NativeViewAccessibilityAuraLinux::GetParent() {
-  gfx::NativeViewAccessible parent = NativeViewAccessibility::GetParent();
-  if (!parent)
-    parent = AuraLinuxApplication::GetInstance()->GetNativeViewAccessible();
-  return parent;
+// static
+std::unique_ptr<NativeViewAccessibility> NativeViewAccessibility::Create(
+    View* view) {
+  AuraLinuxApplication::GetInstance()->RegisterWidget(view->GetWidget());
+  return base::MakeUnique<NativeViewAccessibilityAuraLinux>(view);

[tapted, 2017/02/28 06:29:12]

huhhh .. I guess we can't declare NativeViewAccessibilityAuraLinux's constructor
private because this method is actually on NativeViewAccessibility, so it would
need to be a friend.

(note we probably don't need to reorder the methods in the .cc since they're
different classes - either is fine)

[Patti Lor, 2017/02/28 22:24:24]

Acknowledged.

 }
 
 }  // namespace views