Views a11y: Convert View's NativeViewAccessibility to a unique_ptr.

ui/views/accessibility/native_view_accessibility_auralinux.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/accessibility/native_view_accessibility_auralinux.h"
 
 #include <algorithm>
+#include <memory>
 #include <vector>
 
 #include "base/macros.h"
+#include "base/memory/ptr_util.h"
 #include "base/memory/singleton.h"
 #include "base/stl_util.h"
 #include "ui/accessibility/ax_action_data.h"
 #include "ui/accessibility/ax_enums.h"
 #include "ui/accessibility/ax_node_data.h"
 #include "ui/accessibility/platform/ax_platform_node_auralinux.h"
 #include "ui/accessibility/platform/ax_platform_node_delegate.h"
 #include "ui/gfx/native_widget_types.h"
 #include "ui/views/views_delegate.h"
 #include "ui/views/widget/widget.h"
@@ skipping 121 matching lines @@
 
   ui::AXPlatformNode* platform_node_;
   ui::AXNodeData data_;
   std::vector<Widget*> widgets_;
 
   DISALLOW_COPY_AND_ASSIGN(AuraLinuxApplication);
 };
 
 }  // namespace
 
-// static
-NativeViewAccessibility* NativeViewAccessibility::Create(View* view) {
-  AuraLinuxApplication::GetInstance()->RegisterWidget(view->GetWidget());
-  return new NativeViewAccessibilityAuraLinux(view);
+gfx::NativeViewAccessible NativeViewAccessibilityAuraLinux::GetParent() {
+  gfx::NativeViewAccessible parent = NativeViewAccessibility::GetParent();
+  if (!parent)
+    parent = AuraLinuxApplication::GetInstance()->GetNativeViewAccessible();
+  return parent;
 }
 
 NativeViewAccessibilityAuraLinux::NativeViewAccessibilityAuraLinux(View* view)
     : NativeViewAccessibility(view) {
 }
 
 NativeViewAccessibilityAuraLinux::~NativeViewAccessibilityAuraLinux() {
 }
 
-gfx::NativeViewAccessible NativeViewAccessibilityAuraLinux::GetParent() {
-  gfx::NativeViewAccessible parent = NativeViewAccessibility::GetParent();
-  if (!parent)
-    parent = AuraLinuxApplication::GetInstance()->GetNativeViewAccessible();
-  return parent;
+// static
+std::unique_ptr<NativeViewAccessibility> NativeViewAccessibility::Create(
+    View* view) {
+  AuraLinuxApplication::GetInstance()->RegisterWidget(view->GetWidget());
+  return base::MakeUnique<NativeViewAccessibilityAuraLinux>(view);

[tapted, 2017/02/28 06:29:12]

huhhh .. I guess we can't declare NativeViewAccessibilityAuraLinux's constructor
private because this method is actually on NativeViewAccessibility, so it would
need to be a friend.

(note we probably don't need to reorder the methods in the .cc since they're
different classes - either is fine)

[Patti Lor, 2017/02/28 22:24:24]

Acknowledged.

 }
 
 }  // namespace views