Fix BufferedSpdyFrameTest.OnAltSvc.

Fix BufferedSpdyFrameTest.OnAltSvc.

The mock ALTSVC frame in BufferedSpdyFrameTest.OnAltSvc was not spec compliant
with its non-zero stream id and non-empty origin value.  While this is of no
practical importance, because the framing layer this test is exercising does
not enforce this part of the specification, it is good practice to use spec
compliant data in tests.  This CL splits the test into two: one with
stream id 0 and non-empty origin, and another one with stream id other than
zero and empty origin, both combinations conforming to the specs.

BUG=696653
Review-Url: https://codereview.chromium.org/2718053003
Cr-Commit-Position: refs/heads/master@{#454137}
Committed: https://chromium.googlesource.com/chromium/src/+/ce54af31e8cf2b9a1da25a30b327087afc0862ef

[Bence, 2017-02-27 22:45:16]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 22:45:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bence, 2017-02-27 23:17:12]

bnc@chromium.org changed reviewers:
+ rch@chromium.org

[Bence, 2017-02-27 23:17:13]

Ryan: PTAL.  Thank you.

[commit-bot: I haz the power, 2017-02-27 23:33:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 23:33:31]

Dry run: This issue passed the CQ dry run.

[Bence, 2017-03-01 01:49:44]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 01:50:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 02:57:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 02:57:59]

Dry run: This issue passed the CQ dry run.

[Bence, 2017-03-01 20:12:10]

Description was changed from

==========
Fix mock ALTSVC frames in BufferedSpdyFrameTests.

The mock ALTSVC frame in BufferedSpdyFrameTest.OnAltSvc was not spec compliant
with its non-zero stream id and non-empty origin value.  This test fails with
FLAGS_chromium_http2_flag_spdy_use_http2_frame_decoder_adapter set to true.
This CL splits this one test case out to two, both with valid frames, and
introduces two tests for invalid mock frames.  (Note that with the flag set to
false, BufferedSpdyFramer does not actually enforce the restriction on stream id
and origin, hence the two early returns.)

BUG=696653
==========

to

==========
Fix BufferedSpdyFrameTest.OnAltSvc.

The mock ALTSVC frame in BufferedSpdyFrameTest.OnAltSvc was not spec compliant
with its non-zero stream id and non-empty origin value.  While this is of no
practical importance, because the framing layer this test is exercising does
not enforce this part of the specification, it is good practice to use spec
compliant data in tests.  This CL splits the test into two: one with
stream id 0 and non-empty origin, and another one with stream id other than
zero and empty origin, both combinations conforming to the specs.

BUG=696653
==========

[Bence, 2017-03-01 20:12:22]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 20:13:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 20:51:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 20:51:35]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2017-03-02 01:18:59]

lgtm

[Bence, 2017-03-02 01:26:47]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2017-03-02 01:27:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 01:36:19]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488418007563270,
"parent_rev": "8f2dc13d423abd8414e6bd5624aa516fcb1e683d", "commit_rev":
"ce54af31e8cf2b9a1da25a30b327087afc0862ef"}

[commit-bot: I haz the power, 2017-03-02 01:37:19]

Description was changed from

==========
Fix BufferedSpdyFrameTest.OnAltSvc.

The mock ALTSVC frame in BufferedSpdyFrameTest.OnAltSvc was not spec compliant
with its non-zero stream id and non-empty origin value.  While this is of no
practical importance, because the framing layer this test is exercising does
not enforce this part of the specification, it is good practice to use spec
compliant data in tests.  This CL splits the test into two: one with
stream id 0 and non-empty origin, and another one with stream id other than
zero and empty origin, both combinations conforming to the specs.

BUG=696653
==========

to

==========
Fix BufferedSpdyFrameTest.OnAltSvc.

The mock ALTSVC frame in BufferedSpdyFrameTest.OnAltSvc was not spec compliant
with its non-zero stream id and non-empty origin value.  While this is of no
practical importance, because the framing layer this test is exercising does
not enforce this part of the specification, it is good practice to use spec
compliant data in tests.  This CL splits the test into two: one with
stream id 0 and non-empty origin, and another one with stream id other than
zero and empty origin, both combinations conforming to the specs.

BUG=696653

Review-Url: https://codereview.chromium.org/2718053003
Cr-Commit-Position: refs/heads/master@{#454137}
Committed:
https://chromium.googlesource.com/chromium/src/+/ce54af31e8cf2b9a1da25a30b327...
==========

[commit-bot: I haz the power, 2017-03-02 01:37:22]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ce54af31e8cf2b9a1da25a30b327...