Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2718053002: [wasm] Minor optimization for parallel compilation (Closed)

Created:
3 years, 9 months ago by Clemens Hammacher
Modified:
3 years, 9 months ago
Reviewers:
titzer, ahaas
CC:
Michael Hablich, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Minor optimization for parallel compilation Skip parallel compilation if less than two functions need to be compiled, and skip over imported functions instead of adding nullptrs for them to the compilation_units_ vector. R=titzer@chromium.org, ahaas@chromium.org Review-Url: https://codereview.chromium.org/2718053002 Cr-Commit-Position: refs/heads/master@{#43449} Committed: https://chromium.googlesource.com/v8/v8/+/b2177684cba03edae816ea9779c501a7a47ba6a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/wasm-module.cc View 2 chunks +15 lines, -13 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
Clemens Hammacher
3 years, 9 months ago (2017-02-27 12:45:09 UTC) #5
titzer
lgtm
3 years, 9 months ago (2017-02-27 12:49:14 UTC) #6
ahaas
lgtm
3 years, 9 months ago (2017-02-27 12:52:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718053002/1
3 years, 9 months ago (2017-02-27 12:55:17 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 12:57:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b2177684cba03edae816ea9779c501a7a47...

Powered by Google App Engine
This is Rietveld 408576698