Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2718043005: [Telemetry] Clients expect "Unix" end-of-line from platform.RunCommand (Closed)

Created:
3 years, 9 months ago by perezju
Modified:
3 years, 9 months ago
Reviewers:
sullivan
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Clients expect "Unix" end-of-line from platform.RunCommand A previous change in https://codereview.chromium.org/2709523005 broke some client expectations which assumed end-of-lines are always '\n', while adb on some android devices appears to return '\r\n'. Revert back to the old behaviour. BUG=chromium:696715 Review-Url: https://codereview.chromium.org/2718043005 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/78c8d7338e35e82db61513bb2f328c0764d2fe00

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M telemetry/telemetry/internal/platform/android_platform_backend.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
perezju
3 years, 9 months ago (2017-02-28 10:53:18 UTC) #2
sullivan
lgtm
3 years, 9 months ago (2017-02-28 11:12:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718043005/1
3 years, 9 months ago (2017-02-28 11:12:30 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 11:34:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698