Replace more hardcoded "ash" strings with ash::mojom::kServiceName

Replace more hardcoded "ash" strings with ash::mojom::kServiceName

The ash::mojom::kServiceName constant was introduced in [1] and replaced
some of the hardcoded "ash" strings. This CL finishes that work. It also
removes the ash_util::GetAshServiceName helper function and replaced it
with direct use of ash::mojom::kServiceName.

[1] https://codereview.chromium.org/2710673002/

BUG=697053
Review-Url: https://codereview.chromium.org/2718043002
Cr-Commit-Position: refs/heads/master@{#453636}
Committed: https://chromium.googlesource.com/chromium/src/+/02332dbe5aff4778c597467c4fc62796586464cf

[fwang, 2017-02-27 11:03:36]

Description was changed from

==========
Replace more hardcoded "ash" strings with ash::mojom::kServiceName

The ash::mojom::kServiceName constant was introduced in [1] and replaced
some of the hardcoded "ash" strings. This CL finishes that work. It also
removes the ash_util::GetAshServiceName helper function and replaced it
with direct use of ash::mojom::kServiceName.

[1] https://codereview.chromium.org/2710673002/

BUG=None
==========

to

==========
Replace more hardcoded "ash" strings with ash::mojom::kServiceName

The ash::mojom::kServiceName constant was introduced in [1] and replaced
some of the hardcoded "ash" strings. This CL finishes that work. It also
removes the ash_util::GetAshServiceName helper function and replaced it
with direct use of ash::mojom::kServiceName.

[1] https://codereview.chromium.org/2710673002/

BUG=None
==========

[fwang, 2017-02-27 11:03:45]

The CQ bit was checked by fwang@igalia.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 11:03:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 11:12:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 11:12:40]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fwang, 2017-02-27 16:17:41]

The CQ bit was checked by fwang@igalia.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 16:18:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 16:33:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 16:33:10]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[fwang, 2017-02-27 17:05:53]

The CQ bit was checked by fwang@igalia.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 17:06:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fwang, 2017-02-27 17:48:11]

fwang@igalia.com changed reviewers:
+ achuith@chromium.org, sky@chromium.org

[fwang, 2017-02-27 17:48:11]

PTAL

[commit-bot: I haz the power, 2017-02-27 17:49:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 17:49:41]

Dry run: This issue passed the CQ dry run.

[sky, 2017-02-28 04:20:26]

Can any of the includes to ash_util be removed now?

[fwang, 2017-02-28 08:24:08]

The CQ bit was checked by fwang@igalia.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 08:24:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 09:06:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 09:06:07]

Dry run: This issue passed the CQ dry run.

[fwang, 2017-02-28 12:26:39]

On 2017/02/28 04:20:26, sky wrote:
> Can any of the includes to ash_util be removed now?

Right, I've updated the patch to handle these cases. I actually realized that
includes were useless (independently of the removal of
ash_util::GetAshServiceName) so I opened a follow-up CL
https://codereview.chromium.org/2723503003/

[achuithb, 2017-02-28 15:39:38]

lgtm.

Since you have a few CLs, I think it makes sense to open a cleanup bug and
reference that bug here and in related CLs.

[fwang, 2017-02-28 15:52:19]

Description was changed from

==========
Replace more hardcoded "ash" strings with ash::mojom::kServiceName

The ash::mojom::kServiceName constant was introduced in [1] and replaced
some of the hardcoded "ash" strings. This CL finishes that work. It also
removes the ash_util::GetAshServiceName helper function and replaced it
with direct use of ash::mojom::kServiceName.

[1] https://codereview.chromium.org/2710673002/

BUG=None
==========

to

==========
Replace more hardcoded "ash" strings with ash::mojom::kServiceName

The ash::mojom::kServiceName constant was introduced in [1] and replaced
some of the hardcoded "ash" strings. This CL finishes that work. It also
removes the ash_util::GetAshServiceName helper function and replaced it
with direct use of ash::mojom::kServiceName.

[1] https://codereview.chromium.org/2710673002/

BUG=697053
==========

[fwang, 2017-02-28 15:52:39]

On 2017/02/28 15:39:38, achuithb wrote:
> lgtm.
> 
> Since you have a few CLs, I think it makes sense to open a cleanup bug and
> reference that bug here and in related CLs.

Good point, I've opened
https://bugs.chromium.org/p/chromium/issues/detail?id=697053

[sky, 2017-02-28 17:42:07]

LGTM

[fwang, 2017-02-28 17:43:57]

The CQ bit was checked by fwang@igalia.com

[commit-bot: I haz the power, 2017-02-28 17:44:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 17:48:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488303837352930,
"parent_rev": "7280d1ca595f25bafc9577802f9d3c4430c9f7e0", "commit_rev":
"02332dbe5aff4778c597467c4fc62796586464cf"}

[commit-bot: I haz the power, 2017-02-28 17:49:23]

Description was changed from

==========
Replace more hardcoded "ash" strings with ash::mojom::kServiceName

The ash::mojom::kServiceName constant was introduced in [1] and replaced
some of the hardcoded "ash" strings. This CL finishes that work. It also
removes the ash_util::GetAshServiceName helper function and replaced it
with direct use of ash::mojom::kServiceName.

[1] https://codereview.chromium.org/2710673002/

BUG=697053
==========

to

==========
Replace more hardcoded "ash" strings with ash::mojom::kServiceName

The ash::mojom::kServiceName constant was introduced in [1] and replaced
some of the hardcoded "ash" strings. This CL finishes that work. It also
removes the ash_util::GetAshServiceName helper function and replaced it
with direct use of ash::mojom::kServiceName.

[1] https://codereview.chromium.org/2710673002/

BUG=697053

Review-Url: https://codereview.chromium.org/2718043002
Cr-Commit-Position: refs/heads/master@{#453636}
Committed:
https://chromium.googlesource.com/chromium/src/+/02332dbe5aff4778c597467c4fc6...
==========

[commit-bot: I haz the power, 2017-02-28 17:49:25]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/02332dbe5aff4778c597467c4fc6...