Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2718023002: //third_party/WebKit/Source/core: include v8 as a user, not system, header (Closed)

Created:
3 years, 9 months ago by dcheng
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews, shans, dshwang, eae+blinkwatch, apavlov+blink_chromium.org, kinuko+worker_chromium.org, rwlbuis, caseq+blink_chromium.org, blink-reviews-html_chromium.org, chasej+watch_chromium.org, Justin Novosad, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, devtools-reviews_chromium.org, blink-reviews, falken+watch_chromium.org, blink-worker-reviews_chromium.org, Eric Willigers, rjwright, sof, lushnikov+blink_chromium.org, iclelland+watch_chromuim.org, darktears, ajuma+watch-canvas_chromium.org, blink-reviews-animation_chromium.org, shimazu+worker_chromium.org, pfeldman+blink_chromium.org, horo+watch_chromium.org, blink-reviews-frames_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

//third_party/WebKit/Source/core: include v8 as a user, not system, header Note: due to an issue with v8's GN files, files that use include v8 inspector headers are being skipped for now. BUG=688155 Review-Url: https://codereview.chromium.org/2718023002 Cr-Commit-Position: refs/heads/master@{#453190} Committed: https://chromium.googlesource.com/chromium/src/+/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7

Patch Set 1 #

Patch Set 2 : Fix plugin/BUILD.gn deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -47 lines) Patch
M third_party/WebKit/Source/core/animation/AnimationTestHelper.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/EffectInputTest.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/TimingInputTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMTypedArray.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/ErrorEvent.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/PerformanceMonitor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTaskRunner.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/resource/ImageResource.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/resource/ImageResourceContent.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/plugins/BUILD.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/plugins/PluginView.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/streams/ReadableStreamController.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/streams/ReadableStreamOperations.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/streams/ReadableStreamOperationsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/streams/UnderlyingSourceBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/GCObservation.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/timing/MemoryInfo.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerBackingThread.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
dcheng
3 years, 9 months ago (2017-02-27 09:20:46 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-02-27 09:21:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718023002/20001
3 years, 9 months ago (2017-02-27 09:25:55 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 11:26:52 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b9e58094ba5883ab20514b21bffd...

Powered by Google App Engine
This is Rietveld 408576698