Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: content/public/browser/payment_app_provider.h

Issue 2718013004: PaymentApp: Implement respondWith() in PaymentRequestEvent. (content side) (Closed)
Patch Set: PaymentApp: Implement respondWith() in PaymentRequestEvent. (content side) Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/payment_app_provider.h
diff --git a/content/public/browser/payment_app_provider.h b/content/public/browser/payment_app_provider.h
index 5a70e02f3125106b3247804e53aac9288fc9e276..973f1423cd88a7dd56a3888ad8d68db670d4f6d7 100644
--- a/content/public/browser/payment_app_provider.h
+++ b/content/public/browser/payment_app_provider.h
@@ -31,6 +31,8 @@ class CONTENT_EXPORT PaymentAppProvider {
std::pair<int64_t, payments::mojom::PaymentAppManifestPtr>;
please use gerrit instead 2017/03/21 16:09:41 #include "components/payments/content/payment_app.
zino 2017/03/22 18:04:44 Done.
using Manifests = std::vector<ManifestWithID>;
using GetAllManifestsCallback = base::Callback<void(Manifests)>;
please use gerrit instead 2017/03/21 16:09:41 Is it possible to use the move-only base::OnceCall
+ using InvokePaymentAppCallback =
+ base::Callback<void(payments::mojom::PaymentAppResponsePtr)>;
please use gerrit instead 2017/03/21 16:09:41 Is base::OnceCallback usable here?
// Should be accessed only on the UI thread.
virtual void GetAllManifests(BrowserContext* browser_context,
@@ -38,7 +40,8 @@ class CONTENT_EXPORT PaymentAppProvider {
virtual void InvokePaymentApp(
BrowserContext* browser_context,
int64_t registration_id,
please use gerrit instead 2017/03/21 16:09:41 #include <stdint.h>
zino 2017/03/22 18:04:44 Done.
- payments::mojom::PaymentAppRequestPtr app_request) = 0;
+ payments::mojom::PaymentAppRequestPtr app_request,
+ const InvokePaymentAppCallback& callback) = 0;
please use gerrit instead 2017/03/21 16:09:41 If you use base::OnceCallback, then there's no nee
protected:
virtual ~PaymentAppProvider() {}

Powered by Google App Engine
This is Rietveld 408576698