PaymentApp: Implement respondWith() in PaymentRequestEvent. (content side)

content/public/browser/payment_app_provider.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_PAYMENT_APP_PROVIDER_H_
 #define CONTENT_PUBLIC_BROWSER_PAYMENT_APP_PROVIDER_H_
 
 #include <utility>
 #include <vector>
 
@@ skipping 10 matching lines @@
 // All methods must be called on the UI thread.
 class CONTENT_EXPORT PaymentAppProvider {
  public:
   // This static function is actually implemented in PaymentAppProviderImpl.cc.
   // Please see: content/browser/payments/payment_app_provider_impl.cc
   static PaymentAppProvider* GetInstance();
 
   // The ManifestWithID is a pair of the service worker registration id and
   // the payment app manifest data associated with it.
   using ManifestWithID =
       std::pair<int64_t, payments::mojom::PaymentAppManifestPtr>;

[please use gerrit instead, 2017/03/21 16:09:41]

#include "components/payments/content/payment_app.mojom.h"

[zino, 2017/03/22 18:04:44]

Done.

   using Manifests = std::vector<ManifestWithID>;
   using GetAllManifestsCallback = base::Callback<void(Manifests)>;

[please use gerrit instead, 2017/03/21 16:09:41]

Is it possible to use the move-only base::OnceCallback? See
https://chromium.googlesource.com/chromium/src/+/master/docs/callback.md for
more info.

+  using InvokePaymentAppCallback =
+      base::Callback<void(payments::mojom::PaymentAppResponsePtr)>;

[please use gerrit instead, 2017/03/21 16:09:41]

Is base::OnceCallback usable here?

 
   // Should be accessed only on the UI thread.
   virtual void GetAllManifests(BrowserContext* browser_context,
                                const GetAllManifestsCallback& callback) = 0;

[please use gerrit instead, 2017/03/21 16:09:41]

If you use base::OnceCallback to define GetAllManifestsCallback, then remove
const-ref from the callback parameter, because it's move-only. That is:

virtual void GetAllManifests(BrowserContext* browser_context,
GetAllManifestsCallback callback) = 0;

   virtual void InvokePaymentApp(
       BrowserContext* browser_context,
       int64_t registration_id,

[please use gerrit instead, 2017/03/21 16:09:41]

#include <stdint.h>

[zino, 2017/03/22 18:04:44]

Done.

-      payments::mojom::PaymentAppRequestPtr app_request) = 0;
+      payments::mojom::PaymentAppRequestPtr app_request,
+      const InvokePaymentAppCallback& callback) = 0;

[please use gerrit instead, 2017/03/21 16:09:41]

If you use base::OnceCallback, then there's no need for const-ref of the
callback paramater.

 
  protected:
   virtual ~PaymentAppProvider() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_PAYMENT_APP_PROVIDER_H_