Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2717983002: MD Settings: remove button-ness of magnifying glass in subpage search (Closed)

Created:
3 years, 9 months ago by Dan Beam
Modified:
3 years, 9 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: remove button-ness of magnifying glass in subpage search Clicking/tapping it did nothing, it just added ripples and weight to the page and wasn't labelled. R=tommycli@chromium.org BUG=693373 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2717983002 Cr-Commit-Position: refs/heads/master@{#453357} Committed: https://chromium.googlesource.com/chromium/src/+/6c8849f73233c57e96ed90f730cb096d42ebae03

Patch Set 1 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/resources/settings/settings_page/settings_subpage_search.html View 3 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 17 (13 generated)
Dan Beam
3 years, 9 months ago (2017-02-27 05:44:45 UTC) #3
tommycli
lgtm
3 years, 9 months ago (2017-02-27 21:34:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2717983002/20001
3 years, 9 months ago (2017-02-27 22:06:25 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 22:14:54 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6c8849f73233c57e96ed90f730cb...

Powered by Google App Engine
This is Rietveld 408576698