Improve painting of cros tray separators.

Improve painting of cros tray separators.

Also add Canvas::Draw1PxLine for drawing a single pixel line at any scale factor.

BUG=696884
Review-Url: https://codereview.chromium.org/2717973004
Cr-Commit-Position: refs/heads/master@{#453844}
Committed: https://chromium.googlesource.com/chromium/src/+/bb53c198f388b19ca0b1108252d6fe7b39cd6f95

[Evan Stade, 2017-02-28 05:06:47]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 05:07:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2017-02-28 05:07:48]

estade@chromium.org changed reviewers:
+ sadrul@chromium.org, tdanderson@chromium.org

[Evan Stade, 2017-02-28 05:07:49]

+tdanderson for ash, +sadrul for canvas

https://codereview.chromium.org/2717973004/diff/20001/ash/common/system/tray/...
File ash/common/system/tray/tray_background_view.cc (left):

https://codereview.chromium.org/2717973004/diff/20001/ash/common/system/tray/...
ash/common/system/tray/tray_background_view.cc:605: flags.setAntiAlias(true);
this is a little crazy and requires explanation.

You will notice that the old tray separator color was white * 0.6a, whereas the
spec is white * 0.3a. However it still sorta looked right, because the values we
pass to DrawLine are off of pixel centers (whole numbers that lie between two
pixels) and we enabled anti aliasing, so you get two ~half filled pixels. We
only actually saw one of the two pixels because it was drawn right on the canvas
border, so the other pixel was clipped.

[commit-bot: I haz the power, 2017-02-28 05:26:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 05:26:10]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[sadrul, 2017-02-28 16:51:54]

lgtm

[sadrul, 2017-02-28 16:52:50]

Can you mention in the CL desc that you are adding Canvas::Draw1pxLine()?

[tdanderson, 2017-02-28 17:18:19]

https://codereview.chromium.org/2717973004/diff/40001/ash/common/system/tray/...
File ash/common/system/tray/tray_background_view.cc (right):

https://codereview.chromium.org/2717973004/diff/40001/ash/common/system/tray/...
ash/common/system/tray/tray_background_view.cc:587: const SkColor color =
SkColorSetA(SK_ColorWHITE, 0x4D);
Why are you changing the alpha from 0x99 to 0x4D?

https://codereview.chromium.org/2717973004/diff/40001/ash/common/system/tray/...
ash/common/system/tray/tray_background_view.cc:592:
(GetShelfConstant(SHELF_SIZE) - kTrayItemSize) / 2);
looks like a case of a missing )

https://codereview.chromium.org/2717973004/diff/40001/ash/common/system/tray/...
ash/common/system/tray/tray_background_view.cc:596: const gfx::PointF
point((GetShelfConstant(SHELF_SIZE) - kTrayItemSize) / 2,
I think your x and y should be reversed here

[Evan Stade, 2017-02-28 18:15:26]

https://codereview.chromium.org/2717973004/diff/40001/ash/common/system/tray/...
File ash/common/system/tray/tray_background_view.cc (right):

https://codereview.chromium.org/2717973004/diff/40001/ash/common/system/tray/...
ash/common/system/tray/tray_background_view.cc:587: const SkColor color =
SkColorSetA(SK_ColorWHITE, 0x4D);
On 2017/02/28 17:18:19, tdanderson wrote:
> Why are you changing the alpha from 0x99 to 0x4D?

see my comment that I sent out with the review for explanation.

https://codereview.chromium.org/2717973004/diff/40001/ash/common/system/tray/...
ash/common/system/tray/tray_background_view.cc:596: const gfx::PointF
point((GetShelfConstant(SHELF_SIZE) - kTrayItemSize) / 2,
On 2017/02/28 17:18:19, tdanderson wrote:
> I think your x and y should be reversed here

I don't think so. This is for vertical shelf.

[Evan Stade, 2017-02-28 18:17:15]

Description was changed from

==========
Improve painting of cros tray separators.

BUG=696884
==========

to

==========
Improve painting of cros tray separators.

Also add Canvas::Draw1PxLine for drawing a single pixel line at any scale
factor.

BUG=696884
==========

[tdanderson, 2017-02-28 18:41:34]

LGTM with compile failures addressed.

https://codereview.chromium.org/2717973004/diff/40001/ash/common/system/tray/...
File ash/common/system/tray/tray_background_view.cc (right):

https://codereview.chromium.org/2717973004/diff/40001/ash/common/system/tray/...
ash/common/system/tray/tray_background_view.cc:587: const SkColor color =
SkColorSetA(SK_ColorWHITE, 0x4D);
On 2017/02/28 18:15:26, Evan Stade wrote:
> On 2017/02/28 17:18:19, tdanderson wrote:
> > Why are you changing the alpha from 0x99 to 0x4D?
> 
> see my comment that I sent out with the review for explanation.

Acknowledged.

https://codereview.chromium.org/2717973004/diff/40001/ash/common/system/tray/...
ash/common/system/tray/tray_background_view.cc:596: const gfx::PointF
point((GetShelfConstant(SHELF_SIZE) - kTrayItemSize) / 2,
On 2017/02/28 18:15:26, Evan Stade wrote:
> On 2017/02/28 17:18:19, tdanderson wrote:
> > I think your x and y should be reversed here
> 
> I don't think so. This is for vertical shelf.

My mistake, I was just looking at the current code's definition of x and y,
neglecting to notice that these are swapped by line 207 for a vertical shelf.

[Evan Stade, 2017-03-01 00:37:51]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-03-01 00:37:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org, sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2717973004/#ps60001
(title: "restore include")

[commit-bot: I haz the power, 2017-03-01 00:38:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 02:23:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 02:23:33]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2017-03-01 04:10:14]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2017-03-01 04:10:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 04:50:27]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488341414544970,
"parent_rev": "003bccb313db261e4439ebf2adb8f5dcb13710a9", "commit_rev":
"bb53c198f388b19ca0b1108252d6fe7b39cd6f95"}

[commit-bot: I haz the power, 2017-03-01 04:51:21]

Description was changed from

==========
Improve painting of cros tray separators.

Also add Canvas::Draw1PxLine for drawing a single pixel line at any scale
factor.

BUG=696884
==========

to

==========
Improve painting of cros tray separators.

Also add Canvas::Draw1PxLine for drawing a single pixel line at any scale
factor.

BUG=696884

Review-Url: https://codereview.chromium.org/2717973004
Cr-Commit-Position: refs/heads/master@{#453844}
Committed:
https://chromium.googlesource.com/chromium/src/+/bb53c198f388b19ca0b1108252d6...
==========

[commit-bot: I haz the power, 2017-03-01 04:51:22]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/bb53c198f388b19ca0b1108252d6...