Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2717973004: Improve painting of cros tray separators. (Closed)

Created:
3 years, 9 months ago by Evan Stade
Modified:
3 years, 9 months ago
Reviewers:
tdanderson, sadrul
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve painting of cros tray separators. Also add Canvas::Draw1PxLine for drawing a single pixel line at any scale factor. BUG=696884 Review-Url: https://codereview.chromium.org/2717973004 Cr-Commit-Position: refs/heads/master@{#453844} Committed: https://chromium.googlesource.com/chromium/src/+/bb53c198f388b19ca0b1108252d6fe7b39cd6f95

Patch Set 1 #

Patch Set 2 : self review #

Total comments: 1

Patch Set 3 : git cl try #

Total comments: 7

Patch Set 4 : restore include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -39 lines) Patch
M ash/common/system/tray/tray_background_view.cc View 1 3 2 chunks +17 lines, -35 lines 0 comments Download
M ash/common/system/tray/tray_constants.h View 1 chunk +1 line, -2 lines 0 comments Download
M ash/common/system/tray/tray_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/canvas.h View 2 chunks +4 lines, -1 line 0 comments Download
M ui/gfx/canvas.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
Evan Stade
+tdanderson for ash, +sadrul for canvas https://codereview.chromium.org/2717973004/diff/20001/ash/common/system/tray/tray_background_view.cc File ash/common/system/tray/tray_background_view.cc (left): https://codereview.chromium.org/2717973004/diff/20001/ash/common/system/tray/tray_background_view.cc#oldcode605 ash/common/system/tray/tray_background_view.cc:605: flags.setAntiAlias(true); this is ...
3 years, 9 months ago (2017-02-28 05:07:49 UTC) #4
sadrul
lgtm
3 years, 9 months ago (2017-02-28 16:51:54 UTC) #7
sadrul
Can you mention in the CL desc that you are adding Canvas::Draw1pxLine()?
3 years, 9 months ago (2017-02-28 16:52:50 UTC) #8
tdanderson
https://codereview.chromium.org/2717973004/diff/40001/ash/common/system/tray/tray_background_view.cc File ash/common/system/tray/tray_background_view.cc (right): https://codereview.chromium.org/2717973004/diff/40001/ash/common/system/tray/tray_background_view.cc#newcode587 ash/common/system/tray/tray_background_view.cc:587: const SkColor color = SkColorSetA(SK_ColorWHITE, 0x4D); Why are you ...
3 years, 9 months ago (2017-02-28 17:18:19 UTC) #9
Evan Stade
https://codereview.chromium.org/2717973004/diff/40001/ash/common/system/tray/tray_background_view.cc File ash/common/system/tray/tray_background_view.cc (right): https://codereview.chromium.org/2717973004/diff/40001/ash/common/system/tray/tray_background_view.cc#newcode587 ash/common/system/tray/tray_background_view.cc:587: const SkColor color = SkColorSetA(SK_ColorWHITE, 0x4D); On 2017/02/28 17:18:19, ...
3 years, 9 months ago (2017-02-28 18:15:26 UTC) #10
tdanderson
LGTM with compile failures addressed. https://codereview.chromium.org/2717973004/diff/40001/ash/common/system/tray/tray_background_view.cc File ash/common/system/tray/tray_background_view.cc (right): https://codereview.chromium.org/2717973004/diff/40001/ash/common/system/tray/tray_background_view.cc#newcode587 ash/common/system/tray/tray_background_view.cc:587: const SkColor color = ...
3 years, 9 months ago (2017-02-28 18:41:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2717973004/60001
3 years, 9 months ago (2017-03-01 00:38:49 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/399834)
3 years, 9 months ago (2017-03-01 02:23:33 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2717973004/60001
3 years, 9 months ago (2017-03-01 04:10:29 UTC) #19
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 04:51:22 UTC) #22
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/bb53c198f388b19ca0b1108252d6...

Powered by Google App Engine
This is Rietveld 408576698