Rename memory coordinator's variation parameters part 1

Rename memory coordinator's variation parameters part 1

I've started replacing the global memory state with an internal state of
memory coordinator (see [1] for details). There are variation parameters
which are associated with the global memory state calculation and we
should rename them. This CL is a preparation for the renaming;
tentatively get variation parameters from both before- and after-
parameters. After we change server side, we can actually rename
parameters.

[1]
https://docs.google.com/document/d/1XZFywVyc60mJOP76BO--AXlhrgi73noIiD5dhS6LXzA/edit#heading=h.u80pgevn2w7e

BUG=696844
Review-Url: https://codereview.chromium.org/2717953004
Cr-Commit-Position: refs/heads/master@{#453492}
Committed: https://chromium.googlesource.com/chromium/src/+/00e91606d2a09284064419ce93c34b6efe5e4c66

[bashi, 2017-02-28 02:30:48]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 02:31:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bashi, 2017-02-28 03:21:08]

bashi@chromium.org changed reviewers:
+ haraken@chromium.org

[bashi, 2017-02-28 03:21:09]

PTAL

[haraken, 2017-02-28 03:32:00]

LGTM

Sorry for bikeshedding (and changing my mind), but I'm also fine with using
MODERATE & CRITICAL. It would be important that the condition name is consistent
with the one used in MemoryMonitor. I'll defer the decision to Chris.

[bashi, 2017-02-28 03:59:31]

On 2017/02/28 03:32:00, haraken wrote:
> LGTM
> 
> Sorry for bikeshedding (and changing my mind), but I'm also fine with using
> MODERATE & CRITICAL. It would be important that the condition name is
consistent
> with the one used in MemoryMonitor. I'll defer the decision to Chris.

Do you mean MemoryPressureMonitor in base/ ? It actually uses MODERATE/CRITICAL
but we are going to replace it with MC and MemoryPressureMonitor will be gone.

MemoryMonitor of MC world (which lives in content/browser/memory) doesn't have a
notion of memory pressure levels (or memory condition) yet. I think it would be
less confusing to use different terms (WARNING/CRITICAL) in MC world. WDYT?

[commit-bot: I haz the power, 2017-02-28 04:08:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 04:08:56]

Dry run: This issue passed the CQ dry run.

[haraken, 2017-02-28 04:13:48]

On 2017/02/28 03:59:31, bashi wrote:
> On 2017/02/28 03:32:00, haraken wrote:
> > LGTM
> > 
> > Sorry for bikeshedding (and changing my mind), but I'm also fine with using
> > MODERATE & CRITICAL. It would be important that the condition name is
> consistent
> > with the one used in MemoryMonitor. I'll defer the decision to Chris.
> 
> Do you mean MemoryPressureMonitor in base/ ? It actually uses
MODERATE/CRITICAL
> but we are going to replace it with MC and MemoryPressureMonitor will be gone.
> 
> MemoryMonitor of MC world (which lives in content/browser/memory) doesn't have
a
> notion of memory pressure levels (or memory condition) yet. I think it would
be
> less confusing to use different terms (WARNING/CRITICAL) in MC world. WDYT?

Sounds reasonable.

[bashi, 2017-02-28 04:18:15]

On 2017/02/28 04:13:48, haraken wrote:
> On 2017/02/28 03:59:31, bashi wrote:
> > On 2017/02/28 03:32:00, haraken wrote:
> > > LGTM
> > > 
> > > Sorry for bikeshedding (and changing my mind), but I'm also fine with
using
> > > MODERATE & CRITICAL. It would be important that the condition name is
> > consistent
> > > with the one used in MemoryMonitor. I'll defer the decision to Chris.
> > 
> > Do you mean MemoryPressureMonitor in base/ ? It actually uses
> MODERATE/CRITICAL
> > but we are going to replace it with MC and MemoryPressureMonitor will be
gone.
> > 
> > MemoryMonitor of MC world (which lives in content/browser/memory) doesn't
have
> a
> > notion of memory pressure levels (or memory condition) yet. I think it would
> be
> > less confusing to use different terms (WARNING/CRITICAL) in MC world. WDYT?
> 
> Sounds reasonable.

Thanks. Let me submit this CL. We can revisit naming later.

[bashi, 2017-02-28 04:18:19]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2017-02-28 04:18:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 04:25:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488255499588280, "parent_rev":
"b100b01258f1db7595e83af0567f518717c2d35c", "commit_rev":
"00e91606d2a09284064419ce93c34b6efe5e4c66"}

[commit-bot: I haz the power, 2017-02-28 04:25:59]

Description was changed from

==========
Rename memory coordinator's variation parameters part 1

I've started replacing the global memory state with an internal state of
memory coordinator (see [1] for details). There are variation parameters
which are associated with the global memory state calculation and we
should rename them. This CL is a preparation for the renaming;
tentatively get variation parameters from both before- and after-
parameters. After we change server side, we can actually rename
parameters.

[1]
https://docs.google.com/document/d/1XZFywVyc60mJOP76BO--AXlhrgi73noIiD5dhS6LX...

BUG=696844
==========

to

==========
Rename memory coordinator's variation parameters part 1

I've started replacing the global memory state with an internal state of
memory coordinator (see [1] for details). There are variation parameters
which are associated with the global memory state calculation and we
should rename them. This CL is a preparation for the renaming;
tentatively get variation parameters from both before- and after-
parameters. After we change server side, we can actually rename
parameters.

[1]
https://docs.google.com/document/d/1XZFywVyc60mJOP76BO--AXlhrgi73noIiD5dhS6LX...

BUG=696844

Review-Url: https://codereview.chromium.org/2717953004
Cr-Commit-Position: refs/heads/master@{#453492}
Committed:
https://chromium.googlesource.com/chromium/src/+/00e91606d2a09284064419ce93c3...
==========

[commit-bot: I haz the power, 2017-02-28 04:26:00]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/00e91606d2a09284064419ce93c3...