Fix cc/paint skia type mismatches

Fix cc/paint skia type mismatches

This patch is part of this larger change here that will make
SkCanvas/PaintCanvas, SkPaint/PaintFlags, and SkPicture/PaintRecord
fully different types: https://codereview.chromium.org/2690583002

This patch fixes up spots where the wrong type is being used.

BUG=671433
Review-Url: https://codereview.chromium.org/2717943002
Cr-Commit-Position: refs/heads/master@{#454141}
Committed: https://chromium.googlesource.com/chromium/src/+/11266b8b9ebefbfc5ddb4156c194318ed2eb3a68

[enne (OOO), 2017-02-27 01:15:07]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 01:15:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[enne (OOO), 2017-02-27 01:16:46]

enne@chromium.org changed reviewers:
+ ddorwin@chromium.org, jochen@chromium.org, sky@chromium.org

[commit-bot: I haz the power, 2017-02-27 01:31:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 01:31:40]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[enne (OOO), 2017-02-27 01:37:53]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 01:38:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[enne (OOO), 2017-02-27 01:50:34]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 01:50:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 03:51:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 03:51:20]

Dry run: This issue passed the CQ dry run.

[enne (OOO), 2017-02-27 05:20:54]

sky: ash, chrome/browser
jochen: components, content
ddorwin: media

This should all be pretty straightforward.  Sorry for another tedious patch like
this, but it's quite close to not being a typedef and I'm trying to split up the
final patch.

https://codereview.chromium.org/2717943002/diff/1/ash/common/shelf/app_list_b...
File ash/common/shelf/app_list_button.cc (right):

https://codereview.chromium.org/2717943002/diff/1/ash/common/shelf/app_list_b...
ash/common/shelf/app_list_button.cc:169: bg_flags.setAntiAlias(true);
Antialiasing is the only use of setFlags, so am cleaning up the future
PaintCanvas interface here by using setAntiAlias directly instead of setFlags.

https://codereview.chromium.org/2717943002/diff/1/content/renderer/render_vie...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/2717943002/diff/1/content/renderer/render_vie...
content/renderer/render_view_impl.cc:2541: cc::PaintCanvas canvas(bitmap);
No need for a pass through here.  Both SkCanvas and cc::PaintCanvas will
construct with a bitmap.

[ddorwin, 2017-02-27 06:15:35]

media/ LGTM

[sky, 2017-02-27 16:42:30]

LGTM

[enne (OOO), 2017-02-28 17:43:20]

(jochen ping?)

[enne (OOO), 2017-02-28 20:25:14]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 20:25:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 22:10:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 22:10:12]

Dry run: This issue passed the CQ dry run.

[enne (OOO), 2017-03-01 00:43:59]

enne@chromium.org changed reviewers:
+ nick@chromium.org, sdefresne@chromium.org

[enne (OOO), 2017-03-01 00:54:42]

components: sdfresne as jochen alternate
content: nick as jochen alternate

[sdefresne, 2017-03-01 01:03:41]

components/ lgtm

[enne (OOO), 2017-03-01 22:40:42]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 22:41:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ncarter (slow), 2017-03-02 00:12:32]

content lgtm

[commit-bot: I haz the power, 2017-03-02 00:43:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 00:43:12]

Dry run: This issue passed the CQ dry run.

[enne (OOO), 2017-03-02 01:35:47]

The CQ bit was checked by enne@chromium.org

[enne (OOO), 2017-03-02 01:35:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
ddorwin@chromium.org, sky@chromium.org, sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2717943002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-02 01:36:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 01:43:51]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488418547836630,
"parent_rev": "c49428ef69cfd173c5d7eaeb39982f44ca68da78", "commit_rev":
"11266b8b9ebefbfc5ddb4156c194318ed2eb3a68"}

[commit-bot: I haz the power, 2017-03-02 01:44:56]

Description was changed from

==========
Fix cc/paint skia type mismatches

This patch is part of this larger change here that will make
SkCanvas/PaintCanvas, SkPaint/PaintFlags, and SkPicture/PaintRecord
fully different types: https://codereview.chromium.org/2690583002

This patch fixes up spots where the wrong type is being used.

BUG=671433
==========

to

==========
Fix cc/paint skia type mismatches

This patch is part of this larger change here that will make
SkCanvas/PaintCanvas, SkPaint/PaintFlags, and SkPicture/PaintRecord
fully different types: https://codereview.chromium.org/2690583002

This patch fixes up spots where the wrong type is being used.

BUG=671433

Review-Url: https://codereview.chromium.org/2717943002
Cr-Commit-Position: refs/heads/master@{#454141}
Committed:
https://chromium.googlesource.com/chromium/src/+/11266b8b9ebefbfc5ddb4156c194...
==========

[commit-bot: I haz the power, 2017-03-02 01:44:58]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/11266b8b9ebefbfc5ddb4156c194...