Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 2717933004: Fix content/common:mojo_bindings dependencies. (Closed)

Created:
3 years, 9 months ago by kotenkov
Modified:
3 years, 9 months ago
Reviewers:
Mathieu, clamy
CC:
chromium-reviews, jam, darin-cc_chromium.org, please use gerrit instead
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix content/common:mojo_bindings dependencies. Move components/payments:payment_app from common deps to mojo_bindings public deps since service_worker/service_worker_event_dispatcher.mojom depends on it. Review-Url: https://codereview.chromium.org/2717933004 Cr-Commit-Position: refs/heads/master@{#453216} Committed: https://chromium.googlesource.com/chromium/src/+/d7e02eb6352ddffd87e9ee7e336b9e2485cdaba7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/common/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
kotenkov
I've experienced compilation problems due to the issue, so here is a fix. PTAL
3 years, 9 months ago (2017-02-27 13:36:07 UTC) #7
clamy
+mathp: does the content/ DEPS change involving components/payments makes sense? Thanks!
3 years, 9 months ago (2017-02-27 14:43:14 UTC) #9
Mathieu
lgtm but FYI payment_app is moving in https://codereview.chromium.org/2713033004/
3 years, 9 months ago (2017-02-27 15:26:19 UTC) #10
kotenkov
On 2017/02/27 15:26:19, Mathieu Perreault wrote: > lgtm but FYI payment_app is moving in > ...
3 years, 9 months ago (2017-02-27 15:30:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2717933004/1
3 years, 9 months ago (2017-02-27 15:31:12 UTC) #13
clamy
lgtm
3 years, 9 months ago (2017-02-27 15:31:27 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 15:35:44 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d7e02eb6352ddffd87e9ee7e336b...

Powered by Google App Engine
This is Rietveld 408576698