Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Issue 2717843002: Purge session storage caches on memory pressure (Closed)

Created:
3 years, 10 months ago by ssid
Modified:
3 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Purge session storage caches on memory pressure The session storage caches are never cleared because the namespace assumes that backing is only file based. The session storage is backed by leveldb database. This change would not accidently delete storage since DOMStorageArea::PurgeMemory also checks if backing is present and commit tasks are done before purging. BUG=696112 Review-Url: https://codereview.chromium.org/2717843002 Cr-Commit-Position: refs/heads/master@{#453403} Committed: https://chromium.googlesource.com/chromium/src/+/c72ce2a231f22abab37a62e41f15a79545ba4cce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/dom_storage/dom_storage_namespace.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
ssid
ptal, thanks
3 years, 10 months ago (2017-02-25 02:23:24 UTC) #2
Marijn Kruisselbrink
good catch, lgtm
3 years, 9 months ago (2017-02-27 22:02:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2717843002/1
3 years, 9 months ago (2017-02-27 22:25:18 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 00:08:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c72ce2a231f22abab37a62e41f15...

Powered by Google App Engine
This is Rietveld 408576698