DevTools: use git cl format --js for PRESUBMIT check

DevTools: use git cl format --js for PRESUBMIT check

This makes our PRESUBMIT and scripts/ code a lot simpler.

BUG=none

Review-Url: https://codereview.chromium.org/2717833002
Cr-Commit-Position: refs/heads/master@{#454090}
Committed: https://chromium.googlesource.com/chromium/src/+/6550f673237d7a07227ada9add543260d662d01e

[chenwilliam, 2017-02-25 02:15:49]

Description was changed from

==========
DevTools: use git cl format --js for PRESUBMIT check

BUG=none
==========

to

==========
DevTools: use git cl format --js for PRESUBMIT check

This makes our PRESUBMIT and scripts/ code a lot simpler.

BUG=none
==========

[chenwilliam, 2017-02-25 02:15:49]

chenwilliam@chromium.org changed reviewers:
+ dgozman@chromium.org

[chenwilliam, 2017-02-25 02:19:22]

ptal

https://codereview.chromium.org/2717833002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/PRESUBMIT.py (left):

https://codereview.chromium.org/2717833002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/PRESUBMIT.py:75: # Use eslint to autofix the
braces
No more braces autofix, but it'll get caught by eslint still.

[dgozman, 2017-02-27 18:36:28]

https://codereview.chromium.org/2717833002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/PRESUBMIT.py (left):

https://codereview.chromium.org/2717833002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/PRESUBMIT.py:75: # Use eslint to autofix the
braces
That's unfortunate. Can we print out the command line to fix things?

https://codereview.chromium.org/2717833002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/PRESUBMIT.py (right):

https://codereview.chromium.org/2717833002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/PRESUBMIT.py:57:
[output_api.PresubmitError("ERROR: Found formatting violations.\nPlease run 'git
cl format --js'")], has_errors=True)
The common script say something like "directory X requires formatting. Please
run git cl format X".

Also, can we just use standard script?

https://codereview.chromium.org/2717833002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/PRESUBMIT.py:158:
results.append(output_api.PresubmitError("ERROR: Bailed out early because
formatting errors were found"))
Do we need to bailout now? Compilation is fast.

[chenwilliam, 2017-02-28 20:28:38]

ptal.

https://codereview.chromium.org/2717833002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/PRESUBMIT.py (left):

https://codereview.chromium.org/2717833002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/PRESUBMIT.py:75: # Use eslint to autofix the
braces
On 2017/02/27 at 18:36:28, dgozman wrote:
> That's unfortunate. Can we print out the command line to fix things?

I can print out "npm run fix-braces" if they get an error. It does take ~8-10
sec now because it's running it over all of front_end (not just changed files)

https://codereview.chromium.org/2717833002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/PRESUBMIT.py (right):

https://codereview.chromium.org/2717833002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/PRESUBMIT.py:57:
[output_api.PresubmitError("ERROR: Found formatting violations.\nPlease run 'git
cl format --js'")], has_errors=True)
On 2017/02/27 at 18:36:28, dgozman wrote:
> The common script say something like "directory X requires formatting. Please
run git cl format X".
> 
> Also, can we just use standard script?

I looked into the precanned check but I'd like to have our own check so:
1) we can tell people about "npm run fix-braces"
2) make it an error and not a warning (which is what the precanned check does).

https://codereview.chromium.org/2717833002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/PRESUBMIT.py:158:
results.append(output_api.PresubmitError("ERROR: Bailed out early because
formatting errors were found"))
On 2017/02/27 at 18:36:28, dgozman wrote:
> Do we need to bailout now? Compilation is fast.

Removed bailout.

[chenwilliam, 2017-03-01 20:34:06]

ptal - I've made it auto-formatting.

[dgozman, 2017-03-01 22:17:12]

lgtm

[chenwilliam, 2017-03-01 22:18:22]

The CQ bit was checked by chenwilliam@chromium.org

[commit-bot: I haz the power, 2017-03-01 22:18:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 23:25:58]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1488406702022700,
"parent_rev": "73dd82d9969add23c5070c12cdbeba8e9e3f13ff", "commit_rev":
"6550f673237d7a07227ada9add543260d662d01e"}

[commit-bot: I haz the power, 2017-03-01 23:26:38]

Description was changed from

==========
DevTools: use git cl format --js for PRESUBMIT check

This makes our PRESUBMIT and scripts/ code a lot simpler.

BUG=none
==========

to

==========
DevTools: use git cl format --js for PRESUBMIT check

This makes our PRESUBMIT and scripts/ code a lot simpler.

BUG=none

Review-Url: https://codereview.chromium.org/2717833002
Cr-Commit-Position: refs/heads/master@{#454090}
Committed:
https://chromium.googlesource.com/chromium/src/+/6550f673237d7a07227ada9add54...
==========

[commit-bot: I haz the power, 2017-03-01 23:26:39]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/6550f673237d7a07227ada9add54...