Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2717713002:
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)
|
Created:
3 years, 10 months ago by ymzhang1 Modified:
3 years, 8 months ago CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.
Adding COMPONENT/TEAM information into OWNERS file
(accessibility-audit).
Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping
Additional Information:
List of components
https://bugs.chromium.org/p/chromium/adminComponents
BUG=679905
R=aboxhall@chromium.org
Review-Url: https://codereview.chromium.org/2717713002
Cr-Commit-Position: refs/heads/master@{#460806}
Committed: https://chromium.googlesource.com/chromium/src/+/76a92450937342766d630d01a28402e06e2f0622
Patch Set 1 #
Messages
Total messages: 19 (9 generated)
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files? Thank you very much!
@aboxhall: Could you please review the added component team information in your owners file third_party/accessibility-audit/OWNERS? Thanks!
dmazzoni@chromium.org changed reviewers: + dmazzoni@chromium.org
The CQ bit was checked by dmazzoni@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
On 2017/03/24 18:22:34, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) Here is the error: ** Presubmit ERRORS ** Missing LGTM from an OWNER for these files: third_party/accessibility-audit/OWNERS Here is the list from third_party/OWNERS ben@chromium.org brettw@chromium.org dglazkov@chromium.org jam@chromium.org jochen@chromium.org klobag@chromium.org sky@chromium.org thakis@chromium.org Any suggestion who would be the proper person to lgtm this file? Thanks!
Description was changed from ========== [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. Adding COMPONENT/TEAM information into OWNERS file (accessibility-audit). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: List of components https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=aboxhall@chromium.org ========== to ========== [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. Adding COMPONENT/TEAM information into OWNERS file (accessibility-audit). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: List of components https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=aboxhall@chromium.org ==========
ymzhang@chromium.org changed reviewers: + ben@chromium.org
ymzhang@chromium.org changed reviewers: + brettw@chromium.org
Hi ben@ brettw@, Could you please help to review and lgtm this change? Thanks!
lgtm
The CQ bit was checked by ymzhang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490892460519230, "parent_rev":
"611254763b178dd9a1680e1e107a09aefb1267cb", "commit_rev":
"76a92450937342766d630d01a28402e06e2f0622"}
Message was sent while issue was closed.
Description was changed from ========== [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. Adding COMPONENT/TEAM information into OWNERS file (accessibility-audit). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: List of components https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=aboxhall@chromium.org ========== to ========== [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. Adding COMPONENT/TEAM information into OWNERS file (accessibility-audit). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: List of components https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=aboxhall@chromium.org Review-Url: https://codereview.chromium.org/2717713002 Cr-Commit-Position: refs/heads/master@{#460806} Committed: https://chromium.googlesource.com/chromium/src/+/76a92450937342766d630d01a284... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/76a92450937342766d630d01a284... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
