Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1263)

Issue 2717653002: Compile more Gallery targets in gyp v2. (Closed)

Created:
3 years, 10 months ago by oka
Modified:
3 years, 9 months ago
Reviewers:
fukino
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Compile more Gallery targets in gyp v2. BUG=636289 TEST=run_compiler. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2717653002 Cr-Commit-Position: refs/heads/master@{#454179} Committed: https://chromium.googlesource.com/chromium/src/+/734113c8b134ef9738d2e2f2287b01fd9e2243bd

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -175 lines) Patch
M ui/file_manager/externs/platform.js View 1 chunk +0 lines, -9 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/compiled_resources.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/gallery/js/compiled_resources.gyp View 1 2 chunks +2 lines, -0 lines 0 comments Download
M ui/file_manager/gallery/js/compiled_resources2.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/gallery/js/gallery.js View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/gallery/js/gallery_scripts.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/commands.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/gallery/js/image_editor/compiled_resources2.gyp View 1 2 2 chunks +19 lines, -12 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_editor.js View 3 chunks +2 lines, -150 lines 0 comments Download
A ui/file_manager/gallery/js/image_editor/image_editor_prompt.js View 1 chunk +152 lines, -0 lines 0 comments Download
M ui/file_manager/gallery/js/slide_mode.js View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
oka
.
3 years, 10 months ago (2017-02-24 09:01:12 UTC) #6
oka
.
3 years, 10 months ago (2017-02-24 09:03:51 UTC) #7
oka
PTAL.
3 years, 10 months ago (2017-02-24 09:04:24 UTC) #10
fukino
lgtm. Sorry for a late response. (I overlooked it.) Please ping me if I don't ...
3 years, 9 months ago (2017-03-02 03:35:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2717653002/40001
3 years, 9 months ago (2017-03-02 03:38:05 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 04:36:40 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/734113c8b134ef9738d2e2f2287b...

Powered by Google App Engine
This is Rietveld 408576698