Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 2717643002: Call out the importance of the --work argument for wpt manifest (Closed)

Created:
3 years, 10 months ago by foolip
Modified:
3 years, 10 months ago
Reviewers:
qyearsley
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call out the importance of the --work argument for wpt manifest R=qyearsley@chromium.org Review-Url: https://codereview.chromium.org/2717643002 Cr-Commit-Position: refs/heads/master@{#452848} Committed: https://chromium.googlesource.com/chromium/src/+/2f19855a573130c5fcda8f3865189d13a9897389

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M docs/testing/web_platform_tests.md View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
foolip
I wasted a bunch of time on this today, PTAL :)
3 years, 10 months ago (2017-02-24 07:25:14 UTC) #3
qyearsley
lgtm
3 years, 10 months ago (2017-02-24 16:36:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2717643002/1
3 years, 10 months ago (2017-02-24 16:37:07 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 16:43:19 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2f19855a573130c5fcda8f386518...

Powered by Google App Engine
This is Rietveld 408576698