Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 2717583002: Improve views::Slider keyboard handling. (Closed)

Created:
3 years, 10 months ago by Evan Stade
Modified:
3 years, 9 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve views::Slider keyboard handling. - more RTL-friendly - handle up and down arrows BUG=663767 Review-Url: https://codereview.chromium.org/2717583002 Cr-Commit-Position: refs/heads/master@{#453272} Committed: https://chromium.googlesource.com/chromium/src/+/d2af662cd05d4c85b9d4936b4bb02ef67a952418

Patch Set 1 #

Patch Set 2 : add test coverage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -16 lines) Patch
M ui/views/controls/slider.cc View 1 chunk +20 lines, -8 lines 0 comments Download
M ui/views/controls/slider_unittest.cc View 1 3 chunks +32 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Evan Stade
3 years, 10 months ago (2017-02-23 21:43:33 UTC) #3
sadrul
lgtm Add a test-case like the existing SliderTest.SliderValueForKeyboard (especially for rtl)?
3 years, 10 months ago (2017-02-25 01:33:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2717583002/20001
3 years, 9 months ago (2017-02-27 17:45:51 UTC) #10
Evan Stade
thanks. test coverage added
3 years, 9 months ago (2017-02-27 17:46:26 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 18:42:17 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d2af662cd05d4c85b9d4936b4bb0...

Powered by Google App Engine
This is Rietveld 408576698