Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2717543002: DevTools ext docs: Add chrome.devtools.panels.themeName (Closed)

Created:
3 years, 10 months ago by paulirish
Modified:
3 years, 9 months ago
Reviewers:
caseq
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, devtools-reviews_chromium.org, extensions-reviews_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools ext docs: Add chrome.devtools.panels.themeName BUG=608869 Review-Url: https://codereview.chromium.org/2717543002 Cr-Commit-Position: refs/heads/master@{#456172} Committed: https://chromium.googlesource.com/chromium/src/+/073706fee0c989101c5c28391400ddeb0a5a4127

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/common/extensions/api/devtools/panels.json View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
paulirish
Adding some docs for an API introduced back in july: https://bugs.chromium.org/p/chromium/issues/detail?id=608869#c3 ptal
3 years, 10 months ago (2017-02-23 20:27:37 UTC) #2
caseq
lgtm
3 years, 9 months ago (2017-03-10 21:26:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2717543002/1
3 years, 9 months ago (2017-03-10 21:27:37 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 21:41:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/073706fee0c989101c5c28391400...

Powered by Google App Engine
This is Rietveld 408576698