Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2717533003: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: List of components https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2717533003 Cr-Commit-Position: refs/heads/master@{#454336} Committed: https://chromium.googlesource.com/chromium/src/+/ee2bbc8ee23bb9361b5cb78feb37099d4a94b150

Patch Set 1 #

Total comments: 3

Patch Set 2 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build_overrides/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M testing/buildbot/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-02-23 20:42:37 UTC) #2
Michael Achenbach
https://codereview.chromium.org/2717533003/diff/1/testing/buildbot/OWNERS File testing/buildbot/OWNERS (right): https://codereview.chromium.org/2717533003/diff/1/testing/buildbot/OWNERS#newcode31 testing/buildbot/OWNERS:31: # COMPONENT: Infra>Platform>Buildbot I don't think Infra>Platform>Buildbot is appropriate ...
3 years, 10 months ago (2017-02-24 09:02:01 UTC) #4
Dirk Pranke
lgtm https://codereview.chromium.org/2717533003/diff/1/testing/buildbot/OWNERS File testing/buildbot/OWNERS (right): https://codereview.chromium.org/2717533003/diff/1/testing/buildbot/OWNERS#newcode31 testing/buildbot/OWNERS:31: # COMPONENT: Infra>Platform>Buildbot I'd use Infra>Client.
3 years, 9 months ago (2017-02-24 21:57:10 UTC) #5
Dirk Pranke
lgtm w/ my suggested change.
3 years, 9 months ago (2017-02-24 21:57:37 UTC) #6
ymzhang1
https://codereview.chromium.org/2717533003/diff/1/testing/buildbot/OWNERS File testing/buildbot/OWNERS (right): https://codereview.chromium.org/2717533003/diff/1/testing/buildbot/OWNERS#newcode31 testing/buildbot/OWNERS:31: # COMPONENT: Infra>Platform>Buildbot On 2017/02/24 21:57:09, Dirk Pranke wrote: ...
3 years, 9 months ago (2017-02-24 22:02:53 UTC) #7
ymzhang1
https://codereview.chromium.org/2717533003/diff/1/testing/buildbot/OWNERS File testing/buildbot/OWNERS (right): https://codereview.chromium.org/2717533003/diff/1/testing/buildbot/OWNERS#newcode31 testing/buildbot/OWNERS:31: # COMPONENT: Infra>Platform>Buildbot On 2017/02/24 21:57:09, Dirk Pranke wrote: ...
3 years, 9 months ago (2017-02-24 22:02:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2717533003/20001
3 years, 9 months ago (2017-03-02 18:15:33 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 19:28:31 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ee2bbc8ee23bb9361b5cb78feb37...

Powered by Google App Engine
This is Rietveld 408576698