Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 2717523003: Update the statuses of various analysis server integration tests. (Closed)

Created:
3 years, 10 months ago by devoncarew
Modified:
3 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update the statuses of various analysis server integration tests. BUG= R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/fbb613a3fe5e013398bcb4d228a2958625aea8cd

Patch Set 1 #

Total comments: 2

Patch Set 2 : move comments #

Messages

Total messages: 7 (2 generated)
devoncarew
3 years, 10 months ago (2017-02-23 21:20:58 UTC) #2
scheglov
lgtm https://codereview.chromium.org/2717523003/diff/1/pkg/analysis_server/test/integration/analysis/error_driver_test.dart File pkg/analysis_server/test/integration/analysis/error_driver_test.dart (right): https://codereview.chromium.org/2717523003/diff/1/pkg/analysis_server/test/integration/analysis/error_driver_test.dart#newcode21 pkg/analysis_server/test/integration/analysis/error_driver_test.dart:21: @failingTest // We see errors here with the ...
3 years, 10 months ago (2017-02-23 21:22:50 UTC) #3
devoncarew
Done (comments moved). https://codereview.chromium.org/2717523003/diff/1/pkg/analysis_server/test/integration/analysis/error_driver_test.dart File pkg/analysis_server/test/integration/analysis/error_driver_test.dart (right): https://codereview.chromium.org/2717523003/diff/1/pkg/analysis_server/test/integration/analysis/error_driver_test.dart#newcode21 pkg/analysis_server/test/integration/analysis/error_driver_test.dart:21: @failingTest // We see errors here ...
3 years, 10 months ago (2017-02-23 21:34:51 UTC) #4
scheglov
Thanks, LGTM.
3 years, 10 months ago (2017-02-23 21:35:52 UTC) #5
devoncarew
3 years, 10 months ago (2017-02-23 22:24:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fbb613a3fe5e013398bcb4d228a2958625aea8cd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698