Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Side by Side Diff: pkg/analysis_server/test/integration/analysis/get_navigation_test.dart

Issue 2717523003: Update the statuses of various analysis server integration tests. (Closed)
Patch Set: move comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'package:analysis_server/plugin/protocol/protocol.dart'; 5 import 'package:analysis_server/plugin/protocol/protocol.dart';
6 import 'package:test/test.dart'; 6 import 'package:test/test.dart';
7 import 'package:test_reflective_loader/test_reflective_loader.dart'; 7 import 'package:test_reflective_loader/test_reflective_loader.dart';
8 8
9 import '../integration_tests.dart'; 9 import '../integration_tests.dart';
10 10
(...skipping 23 matching lines...) Expand all
34 await sendAnalysisGetNavigation(pathname, text.indexOf('Foo foo'), 0); 34 await sendAnalysisGetNavigation(pathname, text.indexOf('Foo foo'), 0);
35 expect(result.targets, hasLength(1)); 35 expect(result.targets, hasLength(1));
36 NavigationTarget target = result.targets.first; 36 NavigationTarget target = result.targets.first;
37 expect(target.kind, ElementKind.CLASS); 37 expect(target.kind, ElementKind.CLASS);
38 expect(target.offset, text.indexOf('Foo {}')); 38 expect(target.offset, text.indexOf('Foo {}'));
39 expect(target.length, 3); 39 expect(target.length, 3);
40 expect(target.startLine, 1); 40 expect(target.startLine, 1);
41 expect(target.startColumn, 7); 41 expect(target.startColumn, 7);
42 } 42 }
43 43
44 // This fails - it returns navigation results for a whitespace area (#28799).
45 @failingTest 44 @failingTest
46 test_navigation_no_result() async { 45 test_navigation_no_result() async {
46 // This fails - it returns navigation results for a whitespace area (#28799) .
47 String pathname = sourcePath('test.dart'); 47 String pathname = sourcePath('test.dart');
48 String text = r''' 48 String text = r'''
49 // 49 //
50 50
51 class Foo {} 51 class Foo {}
52 52
53 class Bar { 53 class Bar {
54 Foo foo; 54 Foo foo;
55 } 55 }
56 '''; 56 ''';
57 writeFile(pathname, text); 57 writeFile(pathname, text);
58 standardAnalysisSetup(); 58 standardAnalysisSetup();
59 59
60 await analysisFinished; 60 await analysisFinished;
61 61
62 AnalysisGetNavigationResult result = 62 AnalysisGetNavigationResult result =
63 await sendAnalysisGetNavigation(pathname, 0, 0); 63 await sendAnalysisGetNavigation(pathname, 0, 0);
64 expect(result.targets, isEmpty); 64 expect(result.targets, isEmpty);
65 } 65 }
66 66
67 @override 67 @override
68 bool get enableNewAnalysisDriver => true; 68 bool get enableNewAnalysisDriver => true;
69 } 69 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698