Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2717483003: [Reading List] Check web state after the distillation delay. (Closed)

Created:
3 years, 10 months ago by Olivier
Modified:
3 years, 10 months ago
Reviewers:
jif
CC:
chromium-reviews, marq+watch_chromium.org, stkhapugin, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Reading List] Check web state after the distillation delay. It is possible that the web state has been released before the timeout of the timer. If this is the case, it means that the distillation was aborted. Early return in that case. There is no Cancelable delayed task. As the current situation is simple (only one task is running at a time), store the ID of the task, and increment it when cancelling. This is inspired by RunIfNotCanceled, but adapted to this much simpler situation. Check the current ID when the task runs. If the ID was incremented, the task is cancelled. BUG=695493 Review-Url: https://codereview.chromium.org/2717483003 Cr-Commit-Position: refs/heads/master@{#452540} Committed: https://chromium.googlesource.com/chromium/src/+/d7e66510bedbf95d90337071155f8b07036cb002

Patch Set 1 #

Patch Set 2 : add task_id #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M ios/chrome/browser/reading_list/reading_list_distiller_page.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M ios/chrome/browser/reading_list/reading_list_distiller_page.mm View 1 4 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Olivier
3 years, 10 months ago (2017-02-23 16:11:45 UTC) #2
Olivier
3 years, 10 months ago (2017-02-23 17:18:45 UTC) #5
Olivier
3 years, 10 months ago (2017-02-23 17:18:46 UTC) #6
jif
lgtm
3 years, 10 months ago (2017-02-23 17:32:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2717483003/20001
3 years, 10 months ago (2017-02-23 17:32:28 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 17:44:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d7e66510bedbf95d90337071155f...

Powered by Google App Engine
This is Rietveld 408576698