Remove DumpWithoutCrashing() from broker_process_dispatcher

Remove DumpWithoutCrashing() from broker_process_dispatcher

There seems to be very few instances of these dumps on the crash server,
but if no one is looking at them, I'd like to remove calls to it.
DumpWithoutCrashing() can hide legitimate crashes due to crash
throttling.

R=yzshen@chromium.org
BUG=610600, 694688
Review-Url: https://codereview.chromium.org/2717473003
Cr-Commit-Position: refs/heads/master@{#452871}
Committed: https://chromium.googlesource.com/chromium/src/+/02612b1e0615618c3350f29f7f54fc836bd25e64

[scottmg, 2017-02-23 23:10:18]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[scottmg, 2017-02-23 23:10:48]

Hi, if this is still providing value, let me know and we can keep it. Thanks

[commit-bot: I haz the power, 2017-02-23 23:10:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 01:57:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 01:57:59]

Dry run: This issue passed the CQ dry run.

[yzshen1, 2017-02-24 18:01:28]

lgtm

[scottmg, 2017-02-24 18:03:14]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2017-02-24 18:03:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 18:09:33]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487959394382620, "parent_rev":
"ef33cbc2c4e56e2aa5c1503b7cbaf0b826c3affe", "commit_rev":
"02612b1e0615618c3350f29f7f54fc836bd25e64"}

[commit-bot: I haz the power, 2017-02-24 18:10:10]

Description was changed from

==========
Remove DumpWithoutCrashing() from broker_process_dispatcher

There seems to be very few instances of these dumps on the crash server,
but if no one is looking at them, I'd like to remove calls to it.
DumpWithoutCrashing() can hide legitimate crashes due to crash
throttling.

R=yzshen@chromium.org
BUG=610600,694688
==========

to

==========
Remove DumpWithoutCrashing() from broker_process_dispatcher

There seems to be very few instances of these dumps on the crash server,
but if no one is looking at them, I'd like to remove calls to it.
DumpWithoutCrashing() can hide legitimate crashes due to crash
throttling.

R=yzshen@chromium.org
BUG=610600,694688

Review-Url: https://codereview.chromium.org/2717473003
Cr-Commit-Position: refs/heads/master@{#452871}
Committed:
https://chromium.googlesource.com/chromium/src/+/02612b1e0615618c3350f29f7f54...
==========

[commit-bot: I haz the power, 2017-02-24 18:10:13]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/02612b1e0615618c3350f29f7f54...

[yzshen1, 2017-02-24 18:10:25]

yzshen@chromium.org changed reviewers:
+ jschuh@chromium.org

[yzshen1, 2017-02-24 18:10:25]

I searched for BrokerProcessDispatcher::OnMessageReceived on our crash server
and didn't see anyone reported by this DumpWithoutCrashing.
So I think it is okay to remove this.

The reason to introduce this DumpWithoutCrashing was to see whether there were
compromised renderers in the real world trying to send these IPC messages.
Removing DumpWithoutCrashing() doesn't make us any less safe because the check
is still there. But +Justin for input of security expert.