Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2717453002: Revert of FrameGenerator should not be created until an AcceleratedWidget is available (Closed)

Created:
3 years, 10 months ago by hajimehoshi
Modified:
3 years, 10 months ago
Reviewers:
Fady Samuel, sky, Saman Sami
CC:
chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of FrameGenerator should not be created until an AcceleratedWidget is available (patchset #6 id:100001 of https://codereview.chromium.org/2694043003/ ) Reason for revert: This might cause the crash (crbug/695371) Original issue's description: > FrameGenerator should not be created until an AcceleratedWidget is available > > FrameGenerator does not have anything useful to do until an > AcceleratedWidget is provided. This CL delays the creation of > FrameGenerator until a widget is available. > > We also remove the unit test because it's not doing anything useful > right now. > > BUG=683732 > > Review-Url: https://codereview.chromium.org/2694043003 > Cr-Commit-Position: refs/heads/master@{#452329} > Committed: https://chromium.googlesource.com/chromium/src/+/c46bbe24124bdef62daa0e396bb4baa2681fd817 TBR=fsamuel@chromium.org,sky@chromium.org,samans@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=683732 Review-Url: https://codereview.chromium.org/2717453002 Cr-Commit-Position: refs/heads/master@{#452446} Committed: https://chromium.googlesource.com/chromium/src/+/cfa63cc0384a8ab0d8dbea6e67543d21716485dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -41 lines) Patch
M services/ui/ws/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/ws/frame_generator.h View 1 chunk +4 lines, -3 lines 0 comments Download
M services/ui/ws/frame_generator.cc View 3 chunks +36 lines, -25 lines 0 comments Download
A services/ui/ws/frame_generator_unittest.cc View 1 chunk +119 lines, -0 lines 0 comments Download
M services/ui/ws/platform_display_default.h View 2 chunks +1 line, -3 lines 0 comments Download
M services/ui/ws/platform_display_default.cc View 4 chunks +7 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
hajimehoshi
Created Revert of FrameGenerator should not be created until an AcceleratedWidget is available
3 years, 10 months ago (2017-02-23 10:06:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2717453002/1
3 years, 10 months ago (2017-02-23 10:06:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/cfa63cc0384a8ab0d8dbea6e67543d21716485dd
3 years, 10 months ago (2017-02-23 10:08:16 UTC) #6
hajimehoshi
3 years, 10 months ago (2017-02-23 11:07:17 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2715533006/ by hajimehoshi@chromium.org.

The reason for reverting is: This was not the culprit of crbug.com/695375 as the
build bot results said. Sorry for confusion.

https://build.chromium.org/p/chromium.win/buildstatus?builder=Win7%20Tests%20...
.

Powered by Google App Engine
This is Rietveld 408576698