Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2717323002: Cookies and AUTH disabled for template_url_fetcher. (Closed)

Created:
3 years, 9 months ago by Ramin Halavati
Modified:
3 years, 9 months ago
Reviewers:
vasilii, Peter Kasting
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cookies and AUTH disabled for template_url_fetcher. Following discussions in https://codereview.chromium.org/2711833003, cookies and auth are disabled for network request of template_url_fetcher. BUG= Review-Url: https://codereview.chromium.org/2717323002 Cr-Commit-Position: refs/heads/master@{#453202} Committed: https://chromium.googlesource.com/chromium/src/+/974a148dff6919ce3bfe8036ca7f47af99bfa78e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M components/search_engines/template_url_fetcher.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
Ramin Halavati
Please review.
3 years, 9 months ago (2017-02-27 12:43:05 UTC) #2
vasilii
lgtm
3 years, 9 months ago (2017-02-27 13:05:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2717323002/1
3 years, 9 months ago (2017-02-27 13:06:22 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 13:49:01 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/974a148dff6919ce3bfe8036ca7f...

Powered by Google App Engine
This is Rietveld 408576698