Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 2717293003: [Media>UI] Fix a media notification update issue when audio focus changes between tabs (Closed)

Created:
3 years, 9 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Media>UI] Fix a media notification update issue when audio focus changes between tabs There's a issue which is caused by the asynchronousness of audio focus. When tab B gains focus from tab A, we will first receive the event that A becomes playing, and then B becomes paused. We should ignore the notification updates when the tab id mismatches the current notification and the tab is paused. BUG=695967 Review-Url: https://codereview.chromium.org/2714993002 Cr-Commit-Position: refs/heads/master@{#453206} (cherry picked from commit 1ee77687069628ebd0bba3ff791a5ee6c8d17b41) Review-Url: https://codereview.chromium.org/2717293003 . Cr-Commit-Position: refs/branch-heads/2987@{#695} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/5dfc4b56d28e35a36a63c77bad993850f966a3fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java View 2 chunks +28 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Zhiqiang Zhang (Slow)
3 years, 9 months ago (2017-02-27 14:54:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5dfc4b56d28e35a36a63c77bad993850f966a3fd.

Powered by Google App Engine
This is Rietveld 408576698