Fix collapsed-border painting for layered table and cells

Fix collapsed-border painting for layered table and cells

BUG=694038
TEST=paint/tables/collapsed-border-layered-table-and-cells.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2717273003
Cr-Commit-Position: refs/heads/master@{#453364}
Committed: https://chromium.googlesource.com/chromium/src/+/67f96fcba8901815194004f7c5778550bf51e3e1

[Xianzhu, 2017-02-27 18:49:40]

Description was changed from

==========
Fix collapsed-border painting for layered table and cells

BUG=694038
TEST=paint/tables/collapsed-border-layered-table-and-cells.html
==========

to

==========
Fix collapsed-border painting for layered table and cells

BUG=694038
TEST=paint/tables/collapsed-border-layered-table-and-cells.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-02-27 18:50:07]

wangxianzhu@chromium.org changed reviewers:
+ wkorman@chromium.org

[wkorman, 2017-02-27 19:46:23]

https://codereview.chromium.org/2717273003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintInvalidator.cpp (right):

https://codereview.chromium.org/2717273003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintInvalidator.cpp:222:
context.paintingLayer->setNeedsPaintPhaseDescendantBlockBackgrounds();
LayoutTable::invalidatePaintIfNeeded already does this, is that not called when
spinvalidation is enabled, or does this cover another case?

https://codereview.chromium.org/2717273003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintInvalidator.cpp:226: if (object ==
context.paintingLayer->layoutObject())
Why change from pointer to operator==? Are there perf ramifications?

[Xianzhu, 2017-02-27 20:22:50]

https://codereview.chromium.org/2717273003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintInvalidator.cpp (right):

https://codereview.chromium.org/2717273003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintInvalidator.cpp:222:
context.paintingLayer->setNeedsPaintPhaseDescendantBlockBackgrounds();
On 2017/02/27 19:46:23, wkorman wrote:
> LayoutTable::invalidatePaintIfNeeded already does this, is that not called
when
> spinvalidation is enabled, or does this cover another case?

LayoutTable::invalidatePaintIfNeeded(PaintInvalidationState) is the
non-spinvalidation path.

https://codereview.chromium.org/2717273003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintInvalidator.cpp:226: if (object ==
context.paintingLayer->layoutObject())
On 2017/02/27 19:46:23, wkorman wrote:
> Why change from pointer to operator==? Are there perf ramifications?

They are the same in binary code, but omitting '&' shortens the source code and
avoids potential errors of comparing address of pointers (e.g. in case that
'object' is changed to a pointer for some reason).

We use references and pointers to LayoutObjects interchangeably in comparison.
See
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/Why$20we$...
for discussion.

[wkorman, 2017-02-27 20:25:40]

lgtm

[Xianzhu, 2017-02-27 20:36:34]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-02-27 20:37:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 22:42:27]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488227794992890, "parent_rev":
"70a5e24e2309d63e582757e0606da685fc12bfd1", "commit_rev":
"67f96fcba8901815194004f7c5778550bf51e3e1"}

[commit-bot: I haz the power, 2017-02-27 22:43:06]

Description was changed from

==========
Fix collapsed-border painting for layered table and cells

BUG=694038
TEST=paint/tables/collapsed-border-layered-table-and-cells.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix collapsed-border painting for layered table and cells

BUG=694038
TEST=paint/tables/collapsed-border-layered-table-and-cells.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2717273003
Cr-Commit-Position: refs/heads/master@{#453364}
Committed:
https://chromium.googlesource.com/chromium/src/+/67f96fcba8901815194004f7c577...
==========

[commit-bot: I haz the power, 2017-02-27 22:43:07]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/67f96fcba8901815194004f7c577...